GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] Revert "[3.9] bpo-38908: Fix issue when non runtime_protocol does not raise TypeError (GH-26067)" by Fidget-Spinner · Pull Request #26077 · python/cpython

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented May 12, 2021 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Reverts #26075

https://bugs.python.org/issue38908

Automerge-Triggered-By: GH:gvanrossum

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Fidget-Spinner
Revert "[3.9] bpo-38908: Fix issue when non runtime_protocol does not…
3ea1c0b 
… raise TypeError (pythonGH-26067) (pythonGH-26075)"

This reverts commit 88136bb.
@Fidget-Spinner
Fidget-Spinner requested review from gvanrossum and ilevkivskyi as code owners May 12, 2021 17:21
@bedevere-bot bedevere-bot added the awaiting review label May 12, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 12, 2021
@Fidget-Spinner Fidget-Spinner mentioned this pull request May 12, 2021
[3.9] bpo-38908: Fix issue when non runtime_protocol does not raise TypeError (GH-26067) #26075
Merged
gvanrossum
gvanrossum approved these changes May 12, 2021
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you're right, let's be safe.

(Is there a what's new entry for this in 3.10? If we're being picky here, it should be mentioned there.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 12, 2021
@gvanrossum gvanrossum added the 🤖 automerge label May 12, 2021
@Fidget-Spinner

Fidget-Spinner commented May 12, 2021

Copy link
Copy Markdown
Member Author

Yeah, you're right, let's be safe.

(Is there a what's new entry for this in 3.10? If we're being picky here, it should be mentioned there.)

Thanks! And no there isn't. I'll work on it tomorrow.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented May 12, 2021

Copy link
Copy Markdown
Contributor

@Fidget-Spinner: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 9b90ce6 into python:3.9 May 12, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label May 12, 2021
@Fidget-Spinner
Fidget-Spinner deleted the revert-26075-backport-c40486a32d branch May 13, 2021 09:04
@AlexWaygood AlexWaygood mentioned this pull request Apr 9, 2023
Backport CPython PR 26067 python/typing_extensions#132
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Fidget-Spinner @miss-islington @gvanrossum @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.