GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] bpo-38908: Fix issue when non runtime_protocol does not raise TypeError (GH-26067) by Fidget-Spinner · Pull Request #26075 · python/cpython

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented May 12, 2021 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(cherry picked from commit c40486a)

Co-authored-by: Yurii Karabas [email protected]

https://bugs.python.org/issue38908

Automerge-Triggered-By: GH:gvanrossum

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Fidget-Spinner and others added 5 commits February 10, 2021 00:24
@Fidget-Spinner
bpo-41824: Add versionadded for typing.ForwardRef docs (python#24224)
9df373a
@Fidget-Spinner
Merge branch '3.9' of https://github.com/Fidget-Spinner/cpython into 3.9
e6aa45f
@Fidget-Spinner
Merge branch '3.9' of https://github.com/python/cpython into 3.9
a32691c
@uriyyo @Fidget-Spinner
bpo-38908: Fix issue when non runtime_protocol failed to raise TypeEr…
a1bee7e 
…ror (python#26067)
@Fidget-Spinner
beep boop
f1b1582
@Fidget-Spinner
Fidget-Spinner requested review from gvanrossum and ilevkivskyi as code owners May 12, 2021 16:04
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 12, 2021
@bedevere-bot bedevere-bot mentioned this pull request May 12, 2021
bpo-38908: Fix issue when non runtime_protocol does not raise TypeError #26067
Merged
@bedevere-bot bedevere-bot added the awaiting review label May 12, 2021
@gvanrossum gvanrossum added the 🤖 automerge label May 12, 2021
gvanrossum
gvanrossum approved these changes May 12, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 12, 2021
@miss-islington
miss-islington merged commit 88136bb into python:3.9 May 12, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label May 12, 2021
@Fidget-Spinner
Fidget-Spinner deleted the backport-c40486a32d branch May 12, 2021 17:07
@Fidget-Spinner

Fidget-Spinner commented May 12, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Wait, @gvanrossum I just realised this is backwards incompatible with previous minor versions of 3.9. If someone previously used it incorrectly it will now throw an error. Should we revert this and keep it 3.10 only? (Sorry for the flip-flop!)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Fidget-Spinner added a commit to Fidget-Spinner/cpython that referenced this pull request May 12, 2021
@Fidget-Spinner
Revert "[3.9] bpo-38908: Fix issue when non runtime_protocol does not…
3ea1c0b 
… raise TypeError (pythonGH-26067) (pythonGH-26075)"

This reverts commit 88136bb.
@Fidget-Spinner Fidget-Spinner mentioned this pull request May 12, 2021
[3.9] Revert "[3.9] bpo-38908: Fix issue when non runtime_protocol does not raise TypeError (GH-26067)" #26077
Merged
@Fidget-Spinner

Fidget-Spinner commented May 12, 2021

Copy link
Copy Markdown
Member Author

Alright, just in case you decide to, I already put the revert PR up at #26077. If you decide against it, please don't hesitate to close it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit that referenced this pull request May 12, 2021
@Fidget-Spinner
[3.9] Revert "[3.9] bpo-38908: Fix issue when non runtime_protocol do…
9b90ce6 
…es not raise TypeError (GH-26067)" (GH-26077)

Reverts #26075

Automerge-Triggered-By: GH:gvanrossum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Fidget-Spinner @gvanrossum @the-knights-who-say-ni @bedevere-bot @miss-islington @uriyyo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.