GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43795: Reword paragraph on specific value for Py_LIMITED_API by encukou · Pull Request #26101 · python/cpython

Conversation

@encukou

@encukou encukou commented May 13, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I spent some time on the wording here. Hopefully it is clearer when the 3 value is explained in terms of its longer equivalent.

https://bugs.python.org/issue43795

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
Reword paragraph on specific value for Py_LIMITED_API
80c3e46
@encukou encukou added the skip news label May 13, 2021
@bedevere-bot bedevere-bot added the awaiting core review label May 13, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 13, 2021
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label May 13, 2021
erlend-aasland
erlend-aasland approved these changes May 13, 2021
View reviewed changes
Fidget-Spinner
Fidget-Spinner approved these changes May 13, 2021
View reviewed changes
corona10
corona10 approved these changes May 13, 2021
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 13, 2021
willingc
willingc approved these changes May 14, 2021
View reviewed changes

@willingc willingc left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @encukou.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@willingc
willingc merged commit ddd30b2 into python:main May 14, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label May 14, 2021
@encukou
encukou deleted the pep652-document branch May 14, 2021 07:52
@encukou encukou added the needs backport to 3.10 label May 14, 2021
@miss-islington

miss-islington commented May 14, 2021

Copy link
Copy Markdown
Contributor

Thanks @encukou for the PR, and @willingc for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented May 14, 2021

Copy link
Copy Markdown

GH-26123 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label May 14, 2021
@encukou

encukou commented May 14, 2021

Copy link
Copy Markdown
Member Author

Thank you for the reviews!
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 14, 2021
@encukou @miss-islington
Reword paragraph on specific value for Py_LIMITED_API (pythonGH-26101)
e38992e 
(cherry picked from commit ddd30b2)

Co-authored-by: Petr Viktorin <[email protected]>
encukou added a commit that referenced this pull request May 14, 2021
@miss-islington @encukou
Reword paragraph on specific value for Py_LIMITED_API (GH-26101) (GH-…
5abc681 
…26123)

(cherry picked from commit ddd30b2)

Co-authored-by: Petr Viktorin <[email protected]>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
[3.10] Correct the order of regen-abidump #27228
Closed
@encukou encukou mentioned this pull request Jun 7, 2022
Implement PEP 652 -- Maintaining the Stable ABI #87961
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willingc willingc willingc approved these changes
@corona10 corona10 corona10 approved these changes
@erlend-aasland erlend-aasland erlend-aasland approved these changes
@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@encukou @miss-islington @bedevere-bot @willingc @corona10 @erlend-aasland @Fidget-Spinner @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.