GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-42972: Fully implement GC protocol for arraymodule types by erlend-aasland · Pull Request #26114 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 13, 2021 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue42972

Automerge-Triggered-By: GH:pablogsal

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added the awaiting review label May 13, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 13, 2021
@erlend-aasland erlend-aasland added the skip news label May 13, 2021
@erlend-aasland

erlend-aasland commented May 13, 2021

Copy link
Copy Markdown
Contributor Author

@pablogsal: I'm adding skip news, as is in GH-26074.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Erlend E. Aasland
bpo-42972: Fully implement GC protocol for arraymodule types
711f59f
@erlend-aasland
erlend-aasland force-pushed the bpo-42972/array branch from 2e26875 to 711f59f Compare May 13, 2021 22:16
@erlend-aasland
erlend-aasland requested a review from corona10 May 13, 2021 22:41
@corona10 corona10 added the needs backport to 3.10 label May 13, 2021
@corona10
corona10 requested review from pablogsal and vstinner May 13, 2021 23:28
pablogsal
pablogsal approved these changes May 25, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 25, 2021
@pablogsal pablogsal added awaiting review 🤖 automerge and removed awaiting merge labels May 25, 2021
@pablogsal
pablogsal merged commit bd404cc into python:main May 25, 2021
@miss-islington

miss-islington commented May 25, 2021

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting review label May 25, 2021
@bedevere-bot

bedevere-bot commented May 25, 2021

Copy link
Copy Markdown

GH-26362 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 label May 25, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2021
Erlend Egeberg Aasland @miss-islington
bpo-42972: Fully implement GC protocol for arraymodule types (pythonG…
156f91f
…H-26114)

(cherry picked from commit bd404cc)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
miss-islington added a commit that referenced this pull request May 25, 2021
@miss-islington Erlend Egeberg Aasland
bpo-42972: Fully implement GC protocol for arraymodule types (GH-26114)
534da74
(cherry picked from commit bd404cc)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@erlend-aasland
erlend-aasland deleted the bpo-42972/array branch May 25, 2021 19:28
@bedevere-bot

bedevere-bot commented May 25, 2021

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Gentoo Non-Debug with X 3.x has failed when building commit bd404cc.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/58/builds/253) and take a look at the build logs.
  4. Check if the failure is related to this commit (bd404cc) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/58/builds/253

Failed tests:

  • test_idle

Failed subtests:

  • test_incremental_editing - idlelib.idle_test.test_colorizer.ColorDelegatorTest

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

416 tests OK.

10 slowest tests:

  • test_peg_generator: 18 min 4 sec
  • test_concurrent_futures: 4 min 10 sec
  • test_tokenize: 4 min 4 sec
  • test_lib2to3: 3 min 20 sec
  • test_unparse: 3 min 18 sec
  • test_multiprocessing_spawn: 2 min 57 sec
  • test_asyncio: 2 min 56 sec
  • test_unicodedata: 1 min 47 sec
  • test_multiprocessing_forkserver: 1 min 45 sec
  • test_gdb: 1 min 36 sec

1 test failed:
test_idle

10 tests skipped:
test_ctypes test_devpoll test_ioctl test_kqueue test_msilib
test_startfile test_winconsoleio test_winreg test_winsound
test_zipfile64

1 re-run test:
test_idle

Total duration: 44 min 50 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/idlelib/idle_test/tkinter_testing_utils.py", line 54, in new_test_method
    raise exception
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/idlelib/idle_test/tkinter_testing_utils.py", line 38, in after_callback
    next(test_generator)
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/idlelib/idle_test/test_colorizer.py", line 597, in test_incremental_editing
    eq(text.tag_nextrange('KEYWORD', '1.0'), ())
AssertionError: Tuples differ: ('1.0', '1.1') != ()


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/idlelib/idle_test/tkinter_testing_utils.py", line 54, in new_test_method
    raise exception
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/idlelib/idle_test/tkinter_testing_utils.py", line 38, in after_callback
    next(test_generator)
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/idlelib/idle_test/test_colorizer.py", line 569, in test_incremental_editing
    eq(text.tag_nextrange('KEYWORD', '1.0'), ('1.0', '1.2'))
AssertionError: Tuples differ: () != ('1.0', '1.2')
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal pablogsal mentioned this pull request Jul 18, 2021
[3.10] Correct the order of regen-abidump #27228
Closed
@vstinner vstinner mentioned this pull request Jun 9, 2022
[C API] Heap types (PyType_FromSpec) must fully implement the GC protocol #87138
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@corona10 corona10 Awaiting requested review from corona10
@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@erlend-aasland @miss-islington @bedevere-bot @pablogsal @corona10 @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.