GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] bpo-33433 Fix private address checking for IPv4 mapped IPv6. (GH-26172) by miss-islington · Pull Request #26189 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 17, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

For IPv4 mapped IPv6 addresses, defer privacy check to the mapped IPv4 address. Solves bug where public mapped IPv4 addresses are considered private by the IPv6 check.

Automerge-Triggered-By: GH:gpshead
(cherry picked from commit 83f0f8d)

Co-authored-by: Pete Wicken [email protected]

https://bugs.python.org/issue33433

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@JamoBox @miss-islington
bpo-33433 Fix private address checking for IPv4 mapped IPv6. (pythonG…
11f0b0d
…H-26172)

For IPv4 mapped IPv6 addresses, defer privacy check to the mapped IPv4 address. Solves bug where public mapped IPv4 addresses are considered private by the IPv6 check.

Automerge-Triggered-By: GH:gpshead
(cherry picked from commit 83f0f8d)

Co-authored-by: Pete Wicken <[email protected]>
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 17, 2021
@bedevere-bot bedevere-bot added sprint type-feature A feature request or enhancement labels May 17, 2021
@bedevere-bot bedevere-bot mentioned this pull request May 17, 2021
bpo-33433 Fix private address checking for IPv4 mapped IPv6. #26172
Merged
@bedevere-bot bedevere-bot added the awaiting review label May 17, 2021
@miss-islington

miss-islington commented May 17, 2021

Copy link
Copy Markdown
Contributor Author

@JamoBox: Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gpshead
gpshead approved these changes May 17, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 17, 2021
@miss-islington
miss-islington merged commit a44bb6d into python:3.10 May 17, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label May 17, 2021
@miss-islington
miss-islington deleted the backport-83f0f8d-3.10 branch May 17, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

sprint type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @gpshead @the-knights-who-say-ni @bedevere-bot @JamoBox
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.