GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-33433 Fix private address checking for IPv4 mapped IPv6. by JamoBox · Pull Request #26172 · python/cpython

Conversation

@JamoBox

@JamoBox JamoBox commented May 16, 2021 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

For IPv4 mapped IPv6 addresses, defer privacy check to the mapped IPv4 address. Solves bug where public mapped IPv4 addresses are considered private by the IPv6 check.

https://bugs.python.org/issue33433

Automerge-Triggered-By: GH:gpshead

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JamoBox
Fix private address checking for IPv4 mapped IPv6.
21b6e92
@bedevere-bot bedevere-bot added the awaiting review label May 16, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 16, 2021
blurb-it Bot and others added 3 commits May 16, 2021 17:48
@blurb-it
📜🤖 Added by blurb_it.
12ad7ef
@gpshead
link to the RFC and add some ReST goodness.
a7f23a4
@gpshead
update docstring to clarify the behavior.
e24bed3
@gpshead gpshead added needs backport to 3.10 sprint type-feature A feature request or enhancement labels May 17, 2021
gpshead
gpshead approved these changes May 17, 2021
View reviewed changes

@gpshead gpshead left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some wording updates to the docstring and news entry.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 17, 2021
@miss-islington

miss-islington commented May 17, 2021

Copy link
Copy Markdown
Contributor

@JamoBox: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented May 17, 2021

Copy link
Copy Markdown
Contributor

@JamoBox: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 83f0f8d into python:main May 17, 2021
@miss-islington

miss-islington commented May 17, 2021

Copy link
Copy Markdown
Contributor

Thanks @JamoBox for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed awaiting merge needs backport to 3.10 labels May 17, 2021
@bedevere-bot

bedevere-bot commented May 17, 2021

Copy link
Copy Markdown

GH-26189 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 17, 2021
@JamoBox @miss-islington
bpo-33433 Fix private address checking for IPv4 mapped IPv6. (pythonG…
11f0b0d 
…H-26172)

For IPv4 mapped IPv6 addresses, defer privacy check to the mapped IPv4 address. Solves bug where public mapped IPv4 addresses are considered private by the IPv6 check.

Automerge-Triggered-By: GH:gpshead
(cherry picked from commit 83f0f8d)

Co-authored-by: Pete Wicken <[email protected]>
miss-islington added a commit that referenced this pull request May 17, 2021
@miss-islington @JamoBox
bpo-33433 Fix private address checking for IPv4 mapped IPv6. (GH-26172)
a44bb6d 
For IPv4 mapped IPv6 addresses, defer privacy check to the mapped IPv4 address. Solves bug where public mapped IPv4 addresses are considered private by the IPv6 check.

Automerge-Triggered-By: GH:gpshead
(cherry picked from commit 83f0f8d)

Co-authored-by: Pete Wicken <[email protected]>
@JamoBox

JamoBox commented May 19, 2021

Copy link
Copy Markdown
Contributor Author

Thanks Gregory!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
[3.10] Correct the order of regen-abidump #27228
Closed
@jstasiak jstasiak mentioned this pull request May 30, 2024
ipaddress: Shared Address Space (100.64.0.0/10) is neither private nor global #119812
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

sprint type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@JamoBox @miss-islington @bedevere-bot @gpshead @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.