GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43795: Add a test for Stable ABI symbol availability using ctypes by encukou · Pull Request #26354 · python/cpython

Conversation

@encukou

@encukou encukou commented May 25, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is a cross-platform check that the symbols are actually
exported in the ABI, not e.g. hidden in a macro.

https://bugs.python.org/issue43795

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
Add a test for Stable ABI symbol availability using ctypes
12e08ff 
This is a cross-platform check that the symbols are actually
exported in the ABI, not e.g. hidden in a macro.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 25, 2021
@bedevere-bot bedevere-bot added the awaiting core review label May 25, 2021
@encukou encukou added the needs backport to 3.10 label May 25, 2021
erlend-aasland
erlend-aasland reviewed May 25, 2021
View reviewed changes
Comment thread Tools/scripts/stable_abi.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@encukou
Rename the test class
c65dc41
@encukou encukou added the skip news label May 25, 2021
@encukou
Remove reference to Py_FrozenMain
4278bc5
@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 1, 2021
@bedevere-bot

bedevere-bot commented Jun 1, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 4278bc5 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 1, 2021
@encukou

encukou commented Jun 1, 2021

Copy link
Copy Markdown
Member Author

Aha, I didn't realize ctypes is an optional module. Thanks, Gentoo Installed with X PR buildbot!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
Skip test when _ctypes is not available
39446ab
@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 1, 2021
@bedevere-bot

bedevere-bot commented Jun 1, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 39446ab 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 1, 2021
@encukou

encukou commented Jun 3, 2021

Copy link
Copy Markdown
Member Author

So, still not quite there:

  • AMD64 Arch Linux TraceRefs PR reports missing symbols PyModule_Create2 and PyModule_FromDefAndSpec2!
  • s390x Fedora Refleaks PR and x86 Gentoo Installed with X PR unrelated (test_asyncio timeout, test_idle failure)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Jun 3, 2021

Copy link
Copy Markdown
Member

test_asyncio timeout

I guess that it's https://bugs.python.org/issue44112 Yesterday, I increased the buildbot timeout from 3 hours to 4 hours to be able to debug this issue.

test_idle failure

I should be fixed: https://bugs.python.org/issue44282
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Jun 3, 2021

Copy link
Copy Markdown
Member

AMD64 Arch Linux TraceRefs PR reports missing symbols PyModule_Create2 and PyModule_FromDefAndSpec2!

I guess that it's a similar issue than https://bugs.python.org/issue44133

We should try to link the Python binary from objects files (.o) rather than using the libpython static library.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Jul 4, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jul 4, 2021
encukou added 3 commits October 21, 2021 13:24
@encukou
Merge main branch
0cf75d2
@encukou
Regenerate the test file
b5f7f0f
@encukou
Skip the test for PyModule_Create2 & PyModule_FromDefAndSpec2
a0c765a 
These aren't exported on some platforms.
All the others should still be tested, though, to make sure
they don't disappear.
@encukou encukou added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section and removed stale Stale PR or inactive for long period of time. labels Oct 21, 2021
@bedevere-bot

bedevere-bot commented Oct 21, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit a0c765a 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 21, 2021
@encukou
encukou merged commit 276468d into python:main Oct 22, 2021
@miss-islington

miss-islington commented Oct 22, 2021

Copy link
Copy Markdown
Contributor

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Oct 22, 2021
@encukou
encukou deleted the pep652-ctypes2 branch October 22, 2021 08:12
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Oct 22, 2021
@bedevere-bot

bedevere-bot commented Oct 22, 2021

Copy link
Copy Markdown

GH-29148 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 22, 2021
@encukou @miss-islington
bpo-43795: Add a test for Stable ABI symbol availability using ctypes (…
a1991a8 
…pythonGH-26354)

This is a cross-platform check that the symbols are actually
exported in the ABI, not e.g. hidden in a macro.

Caveat: PyModule_Create2 & PyModule_FromDefAndSpec2 are skipped.

These aren't exported on some of our buildbots. This is a bug
(bpo-44133). This test now makes sure all the others don't regress.
(cherry picked from commit 276468d)

Co-authored-by: Petr Viktorin <[email protected]>
@encukou encukou mentioned this pull request Jun 7, 2022
Implement PEP 652 -- Maintaining the Stable ABI #87961
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@encukou @bedevere-bot @vstinner @miss-islington @erlend-aasland @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.