GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43693: Clean up the PyCodeObject fields. by ericsnowcurrently · Pull Request #26364 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented May 25, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • move "hottest" fields to the top
  • otherwise group the fields a bit more clearly
  • add co_ncellvars and co_nfreevars

https://bugs.python.org/issue43693

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 5 commits May 25, 2021 13:01
@ericsnowcurrently
Move up the comment about fields using in hashing/comparision.
5ff6c47
@ericsnowcurrently
Group the fields more clearly.
c5aa5ee
@ericsnowcurrently
Add co_ncellvars and co_nfreevars.
9a62e10
@ericsnowcurrently
Use nlocals.
e48f0f0
@ericsnowcurrently
Clarify a comment.
da9618b
@ericsnowcurrently
ericsnowcurrently requested a review from markshannon May 25, 2021 20:19
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 25, 2021
@bedevere-bot bedevere-bot added the awaiting core review label May 25, 2021
@ericsnowcurrently ericsnowcurrently added the skip news label May 25, 2021
This was referenced May 26, 2021
bpo-43693: Add _PyCode_New(). #26375
Merged
bpo-43693: Add _PyCode_New() and do some related cleanup. #26258
Closed
markshannon
markshannon reviewed May 26, 2021
View reviewed changes
Comment thread Objects/codeobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently
Raise ValueError if nlocals != len(varnames), rather than aborting.
ca08205
markshannon
markshannon reviewed May 26, 2021
View reviewed changes
Comment thread Lib/test/test_code.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently
Add a unit test for when co_nlocals != len(co_varnames).
9279114
@markshannon
markshannon merged commit 6cc800d into python:main May 26, 2021
@bedevere-bot bedevere-bot removed the awaiting core review label May 26, 2021
@ericsnowcurrently
ericsnowcurrently deleted the code-object-cleanup-fields branch May 26, 2021 19:21
@ericsnowcurrently ericsnowcurrently mentioned this pull request May 27, 2021
Handle boxing of cell variables in the bytecode. faster-cpython/ideas#41
Closed
@markshannon markshannon mentioned this pull request May 2, 2022
Logically merge cell and locals array. They are already contiguous in memory #87859
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ericsnowcurrently @markshannon @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.