GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-44249 Update README.rst by Ayushparikh-code · Pull Request #26385 · python/cpython

Conversation

@Ayushparikh-code

@Ayushparikh-code Ayushparikh-code commented May 26, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue44249

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Ayushparikh-code
Update README.rst
cc2fa7e
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label May 26, 2021
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir labels May 26, 2021
@blurb-it
📜🤖 Added by blurb_it.
8642a86
@nanjekyejoannah nanjekyejoannah added skip issue skip news labels May 27, 2021
nanjekyejoannah
nanjekyejoannah reviewed May 27, 2021
View reviewed changes

@nanjekyejoannah nanjekyejoannah left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too trivial for a news entry IMHO.

I also, forget if we can really merge changes if authors have not signed the CLA.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Ayushparikh-code Ayushparikh-code changed the title Update README.rst Update README.rst #44249 May 27, 2021
@the-knights-who-say-ni the-knights-who-say-ni added CLA signed and removed CLA not signed labels May 27, 2021
@Ayushparikh-code

Ayushparikh-code commented May 27, 2021

Copy link
Copy Markdown
Contributor Author

This is too trivial for a news entry IMHO.

I also, forget if we can really merge changes if authors have not signed the CLA.

I signed CLA , look over it again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Ayushparikh-code Ayushparikh-code changed the title Update README.rst #44249 bpo:44249 Update README.rst May 27, 2021
@Ayushparikh-code Ayushparikh-code changed the title bpo:44249 Update README.rst bpo-44249 Update README.rst May 27, 2021
zware
zware previously requested changes May 27, 2021
View reviewed changes
Comment thread README.rst Outdated
workload. This is necessary in order to profile the interpreter execution.
Note also that any output, both stdout and stderr, that may appear at this step
workload. This is necessary to profile the interpreter's execution.
Note also that any output, both stdout, and stderr, that may appear at this step

@zware zware May 27, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not change; it's not a list, it's just a sub-section of the sentence. I'm not sure this note is true anymore, though.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@terryjreedy terryjreedy May 28, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am reverting except for 's.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread README.rst Outdated

The final step is to build the actual interpreter, using the information
collected from the instrumented one. The end result will be a Python binary
collected from the instrumented one. The result will be a Python binary

@zware zware May 27, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this needs to change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@terryjreedy terryjreedy May 28, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was 50/50, so reverted.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread README.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Documentation/2021-05-26-18-29-48.bpo-39798.D4UZnR.rst Outdated
@@ -0,0 +1 @@
updated and corrected readme with some grammatical mistakes No newline at end of file

@zware zware May 27, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entry is definitely not needed, but NEWS entries should also have proper grammar :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@terryjreedy terryjreedy May 28, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting review labels May 27, 2021
@bedevere-bot

bedevere-bot commented May 27, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
nanjekyejoannah
nanjekyejoannah reviewed May 27, 2021
View reviewed changes

@nanjekyejoannah nanjekyejoannah left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zware, please do the honors of closing the PR unless @Ayushparikh-code has any rebuttals for the changes proposed.

Edit: I think I misread some of the reviews I guess to mean the change wasn't necessary, my bad.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Ayushparikh-code @zware
Update README.rst
d25a681 
Co-authored-by: Zachary Ware <[email protected]>
Ayushparikh-code
Ayushparikh-code commented May 28, 2021
View reviewed changes

@Ayushparikh-code Ayushparikh-code left a comment

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Ayushparikh-code

Ayushparikh-code commented May 28, 2021

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels May 28, 2021
@bedevere-bot

bedevere-bot commented May 28, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@zware: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot
bedevere-bot requested a review from zware May 28, 2021 02:29
@Ayushparikh-code
Update 2021-05-26-18-29-48.bpo-39798.D4UZnR.rst
79d0deb
Ayushparikh-code
Ayushparikh-code commented May 28, 2021
View reviewed changes

@Ayushparikh-code Ayushparikh-code left a comment

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(●'◡'●)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@terryjreedy terryjreedy removed the skip issue label May 28, 2021
@terryjreedy terryjreedy self-assigned this May 28, 2021
terryjreedy added 6 commits May 28, 2021 15:31
@terryjreedy
Update 2021-05-26-18-29-48.bpo-39798.D4UZnR.rst
08399cb 
Not needed.
@terryjreedy
Update 2021-05-26-18-29-48.bpo-39798.D4UZnR.rst
8911bb6
@terryjreedy
Update 2021-05-26-18-29-48.bpo-39798.D4UZnR.rst
efc7bd4
@terryjreedy
Delete 2021-05-26-18-29-48.bpo-39798.D4UZnR.rst
a74a670
@terryjreedy
Update README.rst
35ace7f
@terryjreedy
Update README.rst
b503274
terryjreedy
terryjreedy approved these changes May 28, 2021
View reviewed changes
Comment thread README.rst
Comment on lines +113 to +114
flags for each flavor. Note that this is just an intermediary step. The
binary resulting from this step is not good for real-life workloads as it has

@terryjreedy terryjreedy May 28, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two changes and one other are correct. Will merge when CI done.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread README.rst Outdated
workload. This is necessary in order to profile the interpreter execution.
Note also that any output, both stdout and stderr, that may appear at this step
workload. This is necessary to profile the interpreter's execution.
Note also that any output, both stdout, and stderr, that may appear at this step

@terryjreedy terryjreedy May 28, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am reverting except for 's.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting change review labels May 28, 2021
@terryjreedy
terryjreedy dismissed zware’s stale review May 28, 2021 19:43

Changes done

@terryjreedy terryjreedy added needs backport to 3.9 labels May 28, 2021
@python python deleted a comment from the-knights-who-say-ni May 28, 2021
@terryjreedy

terryjreedy commented May 28, 2021

Copy link
Copy Markdown
Member

@nanjekyejoannah Trivial changes like this, with no creative content, do not need a CLA, But I still think getting it is better. If nothing else, so the matter is taken care of for next suggestion.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zware
zware approved these changes May 28, 2021
View reviewed changes
@terryjreedy
terryjreedy merged commit acac6c7 into python:main May 28, 2021
@miss-islington

miss-islington commented May 28, 2021

Copy link
Copy Markdown
Contributor

Thanks @Ayushparikh-code for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label May 28, 2021
@bedevere-bot

bedevere-bot commented May 28, 2021

Copy link
Copy Markdown

GH-26434 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2021
@Ayushparikh-code @miss-islington
bpo-44249: Fix 3 README.rst typos (pythonGH-26385)
4b3c24e 
(cherry picked from commit acac6c7)

Co-authored-by: Ayush Parikh <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label May 28, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2021
@Ayushparikh-code @miss-islington
bpo-44249: Fix 3 README.rst typos (pythonGH-26385)
e470d4e 
(cherry picked from commit acac6c7)

Co-authored-by: Ayush Parikh <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label May 28, 2021
@bedevere-bot

bedevere-bot commented May 28, 2021

Copy link
Copy Markdown

GH-26435 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
terryjreedy pushed a commit that referenced this pull request May 28, 2021
@miss-islington @Ayushparikh-code
bpo-44249: Fix 3 README.rst typos (GH-26385)
8f8f2ea 
(cherry picked from commit acac6c7)


Co-authored-by: Ayush Parikh <[email protected]>
terryjreedy pushed a commit that referenced this pull request May 28, 2021
@miss-islington @Ayushparikh-code
bpo-44249: Fix 3 README.rst typos (GH-26385)
7261b29 
(cherry picked from commit acac6c7)

Co-authored-by: Ayush Parikh <[email protected]>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
[3.10] Correct the order of regen-abidump #27228
Closed
@isidentical isidentical mentioned this pull request Aug 12, 2025
Update and Improve README.AIX #83979
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes
@nanjekyejoannah nanjekyejoannah nanjekyejoannah left review comments
@zware zware zware approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@terryjreedy terryjreedy

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@Ayushparikh-code @bedevere-bot @terryjreedy @miss-islington @zware @nanjekyejoannah @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.