GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-38693: Prefer f-strings in importlib.resources (importlib_resources 5.0.6). by jaraco · Pull Request #26387 · python/cpython

Conversation

@jaraco

@jaraco jaraco commented May 26, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue38693

Automerge-Triggered-By: GH:jaraco

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 26, 2021
@bedevere-bot bedevere-bot added the awaiting core review label May 26, 2021
@jaraco jaraco added 🤖 automerge labels May 26, 2021
@jaraco

jaraco commented May 26, 2021

Copy link
Copy Markdown
Member Author

bpo link is wrong
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jaraco
bpo-38693: Prefer f-strings in importlib.resources (importlib_resourc…
17012d9 
…es 5.0.6).
@jaraco
jaraco force-pushed the bpo-38693/importlib-resources-fstrings branch from 9989c18 to 17012d9 Compare May 26, 2021 19:53
@jaraco jaraco changed the title bpo-33693: Prefer f-strings in importlib.resources (importlib_resources 5.0.6). bpo-38693: Prefer f-strings in importlib.resources (importlib_resources 5.0.6). May 26, 2021
@jaraco
jaraco requested a review from gpshead May 26, 2021 20:00
ericvsmith
ericvsmith approved these changes May 26, 2021
View reviewed changes

@ericvsmith ericvsmith left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 26, 2021
@miss-islington

miss-islington commented May 26, 2021

Copy link
Copy Markdown
Contributor

@jaraco: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit f6fbdb9 into main May 26, 2021
@miss-islington
miss-islington deleted the bpo-38693/importlib-resources-fstrings branch May 26, 2021 20:16
@bedevere-bot bedevere-bot removed the awaiting merge label May 26, 2021
@miss-islington

miss-islington commented May 26, 2021

Copy link
Copy Markdown
Contributor

Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 26, 2021
@jaraco @miss-islington
bpo-38693: Prefer f-strings in importlib.resources (importlib_resourc…
5e9af53 
…es 5.0.6). (pythonGH-26387)

Automerge-Triggered-By: GH:jaraco
(cherry picked from commit f6fbdb9)

Co-authored-by: Jason R. Coombs <[email protected]>
@bedevere-bot

bedevere-bot commented May 26, 2021

Copy link
Copy Markdown

GH-26389 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label May 26, 2021
jaraco added a commit that referenced this pull request May 26, 2021
@miss-islington @jaraco
bpo-38693: Prefer f-strings in importlib.resources (importlib_resourc…
97b4576 
…es 5.0.6). (GH-26387) (#26389)

Automerge-Triggered-By: GH:jaraco
(cherry picked from commit f6fbdb9)

Co-authored-by: Jason R. Coombs <[email protected]>

Co-authored-by: Jason R. Coombs <[email protected]>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
[3.10] Correct the order of regen-abidump #27228
Closed
@gpshead gpshead mentioned this pull request May 21, 2022
Use f-strings instead of str.format within importlib #82874
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericvsmith ericvsmith ericvsmith approved these changes
@gpshead gpshead Awaiting requested review from gpshead

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@jaraco @miss-islington @bedevere-bot @ericvsmith @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.