GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] bpo-42972: Fully implement GC protocol for ssl heap types (GH-26370) by miss-islington · Pull Request #26399 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 27, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit dcb8786)

Co-authored-by: Erlend Egeberg Aasland [email protected]

https://bugs.python.org/issue42972

Automerge-Triggered-By: GH:tiran

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend Egeberg Aasland @miss-islington
bpo-42972: Fully implement GC protocol for ssl heap types (pythonGH-2…
033e011 
…6370)

(cherry picked from commit dcb8786)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@miss-islington
miss-islington requested a review from tiran as a code owner May 27, 2021 07:50
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 27, 2021
@miss-islington

miss-islington commented May 27, 2021

Copy link
Copy Markdown
Contributor Author

@erlend-aasland and @tiran: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the skip news label May 27, 2021
@bedevere-bot bedevere-bot mentioned this pull request May 27, 2021
bpo-42972: Fully implement GC protocol for ssl heap types (GH-26370) #26370
Merged
@bedevere-bot bedevere-bot added the awaiting review label May 27, 2021
@tiran tiran added the 🤖 automerge label May 27, 2021
tiran
tiran approved these changes May 27, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 27, 2021
@miss-islington

miss-islington commented May 27, 2021

Copy link
Copy Markdown
Contributor Author

@erlend-aasland and @tiran: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit ea47a8a into python:3.10 May 27, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label May 27, 2021
@miss-islington
miss-islington deleted the backport-dcb8786-3.10 branch May 27, 2021 16:25
kenia58
kenia58 reviewed May 28, 2021
View reviewed changes

@kenia58 kenia58 left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#25939 #26422 #26388 albums.txt](https://github.com/python/cpython/files/6562422/xxx.albums.txt)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
kenia58
kenia58 reviewed May 28, 2021
View reviewed changes

@kenia58 kenia58 left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

``

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
[3.10] Correct the order of regen-abidump #27228
Closed
@vstinner vstinner mentioned this pull request Jun 9, 2022
[C API] Heap types (PyType_FromSpec) must fully implement the GC protocol #87138
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@kenia58 kenia58 kenia58 left review comments
@tiran tiran tiran approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@miss-islington @tiran @kenia58 @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.