GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-42972: Fully implement GC protocol for ssl heap types (GH-26370) by erlend-aasland · Pull Request #26370 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 25, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue42972

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Erlend E. Aasland
bpo-42972: Fully implement GC protocol for ssl heap types
a798fac
@erlend-aasland
erlend-aasland requested a review from tiran as a code owner May 25, 2021 21:28
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 25, 2021
@bedevere-bot bedevere-bot added the awaiting review label May 25, 2021
@erlend-aasland erlend-aasland added needs backport to 3.10 skip news labels May 25, 2021
erlend-aasland
erlend-aasland commented May 25, 2021
View reviewed changes
Comment thread Modules/_ssl.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

@tiran tiran self-assigned this May 25, 2021
tiran
tiran approved these changes May 26, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 26, 2021
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 26, 2021
@bedevere-bot

bedevere-bot commented May 26, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit a798fac 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 26, 2021
@tiran tiran changed the title bpo-42972: Fully implement GC protocol for ssl heap types bpo-42972: Fully implement GC protocol for ssl heap types (GH-26370) May 27, 2021
@tiran
tiran merged commit dcb8786 into python:main May 27, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label May 27, 2021
@miss-islington

miss-islington commented May 27, 2021

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR, and @tiran for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2021
Erlend Egeberg Aasland @miss-islington
bpo-42972: Fully implement GC protocol for ssl heap types (pythonGH-2…
033e011
…6370)

(cherry picked from commit dcb8786)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label May 27, 2021
@bedevere-bot

bedevere-bot commented May 27, 2021

Copy link
Copy Markdown

GH-26399 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland
erlend-aasland deleted the bpo-47972/ssl branch May 27, 2021 07:53
@erlend-aasland

erlend-aasland commented May 27, 2021

Copy link
Copy Markdown
Contributor Author

Thanks, @tiran !

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner pushed a commit that referenced this pull request May 27, 2021
@miss-islington Erlend Egeberg Aasland
bpo-42972: Fully implement GC protocol for ssl heap types (GH-26370) (G…
ea47a8a
…H-26399)

(cherry picked from commit dcb8786)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@pablogsal

pablogsal commented May 28, 2021

Copy link
Copy Markdown
Member

This PR introduced a regression: it added a GC type without fully implementing the GC protocol. See:

https://bugs.python.org/issue44252

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal

pablogsal commented May 28, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Unfortunately, this PR also has introduce reference leaks in the urllib module:

dcb8786a9848516e823e090bb36079678913d8d3 is the first bad commit
commit dcb8786a9848516e823e090bb36079678913d8d3
Author: Erlend Egeberg Aasland <[email protected]>
Date:   Thu May 27 09:50:09 2021 +0200

    [bpo-42972](https://bugs.python.org/issue42972): Fully implement GC protocol for ssl heap types (GH-26370)

 Modules/_ssl.c | 73 ++++++++++++++++++++++++++++++++++++----------------------
 1 file changed, 45 insertions(+), 28 deletions(-)

example failure:

https://buildbot.python.org/all/#/builders/320/builds/41

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal

pablogsal commented May 29, 2021

Copy link
Copy Markdown
Member

Fixed by https://bugs.python.org/issue44252

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal pablogsal mentioned this pull request Jul 18, 2021
[3.10] Correct the order of regen-abidump #27228
Closed
@vstinner vstinner mentioned this pull request Jun 9, 2022
[C API] Heap types (PyType_FromSpec) must fully implement the GC protocol #87138
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@tiran tiran tiran approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@tiran tiran

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@erlend-aasland @bedevere-bot @miss-islington @pablogsal @tiran @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.