GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-44256: Do not expose _functools._list_elem_type. by methane · Pull Request #26416 · python/cpython

Conversation

@methane

@methane methane commented May 28, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

It is for internal use only.

https://bugs.python.org/issue44256

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@methane
bpo-44256: Do not expose _functools._list_elem_type
3a50426 
It is internal use only type.
@methane methane added the needs backport to 3.10 label May 28, 2021
@methane
methane requested a review from rhettinger as a code owner May 28, 2021 02:42
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 28, 2021
@bedevere-bot bedevere-bot added the awaiting core review label May 28, 2021
@methane methane added the skip news label May 28, 2021
@methane
methane requested a review from shihai1991 May 28, 2021 02:44
shihai1991
shihai1991 approved these changes May 28, 2021
View reviewed changes

@shihai1991 shihai1991 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Inada for your PR.
_lru_list_elem doesn't exposed in python level. So I think this PR is acceptable.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@shihai1991 shihai1991 mentioned this pull request May 28, 2021
bpo-42972: Fully implement GC protocol for functools keywrapper and partial types #26363
Merged
erlend-aasland
erlend-aasland approved these changes May 28, 2021
View reviewed changes
@methane
methane merged commit 28be319 into python:main May 28, 2021
@methane
methane deleted the bpo44256 branch May 28, 2021 05:09
@miss-islington

miss-islington commented May 28, 2021

Copy link
Copy Markdown
Contributor

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label May 28, 2021
@bedevere-bot

bedevere-bot commented May 28, 2021

Copy link
Copy Markdown

GH-26418 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label May 28, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2021
@methane @miss-islington
bpo-44256: Do not expose _functools._list_elem_type (pythonGH-26416)
72d8c4e 
It is internal use only type.
(cherry picked from commit 28be319)

Co-authored-by: Inada Naoki <[email protected]>
methane added a commit that referenced this pull request May 28, 2021
@miss-islington @methane
bpo-44256: Do not expose _functools._list_elem_type (GH-26416)
35be1f3 
It is internal use only type.
(cherry picked from commit 28be319)

Co-authored-by: Inada Naoki <[email protected]>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
[3.10] Correct the order of regen-abidump #27228
Closed
@sobolevn sobolevn mentioned this pull request Sep 7, 2022
_functools.KeyWrapper is exposed after convertion to a new module type #96641
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shihai1991 shihai1991 shihai1991 approved these changes
@erlend-aasland erlend-aasland erlend-aasland approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@methane @miss-islington @bedevere-bot @shihai1991 @erlend-aasland @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.