GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-42972: Fully implement GC protocol for xxlimited.Xxo by shihai1991 · Pull Request #26451 · python/cpython

Conversation

@shihai1991

@shihai1991 shihai1991 commented May 29, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue42972

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@shihai1991
Fully implement GC protocol for xxlimited
b6474df
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 29, 2021
@bedevere-bot bedevere-bot added the awaiting review label May 29, 2021
@shihai1991 shihai1991 added the skip news label May 29, 2021
@shihai1991

shihai1991 commented May 29, 2021

Copy link
Copy Markdown
Member Author

@vstinner @pablogsal Hi, victor, pablo. Do we need update this xxlimited template too?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shihai1991
shihai1991 requested review from pablogsal and vstinner May 29, 2021 14:37
@vstinner
vstinner merged commit 4b20f25 into python:main May 31, 2021
@bedevere-bot bedevere-bot removed the awaiting review label May 31, 2021
@vstinner vstinner added the needs backport to 3.10 label May 31, 2021
@miss-islington

miss-islington commented May 31, 2021

Copy link
Copy Markdown
Contributor

Thanks @shihai1991 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented May 31, 2021

Copy link
Copy Markdown

GH-26460 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label May 31, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 31, 2021
@shihai1991 @miss-islington
bpo-42972: Fully implement GC protocol for xxlimited (pythonGH-26451)
2b97e9c 
(cherry picked from commit 4b20f25)

Co-authored-by: Hai Shi <[email protected]>
@vstinner

vstinner commented May 31, 2021

Copy link
Copy Markdown
Member

Merged, thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shihai1991

shihai1991 commented May 31, 2021

Copy link
Copy Markdown
Member Author

Merged, thanks.

Thanks, victor :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal pushed a commit that referenced this pull request May 31, 2021
@miss-islington @shihai1991
bpo-42972: Fully implement GC protocol for xxlimited (GH-26451) (GH-2…
f097d23 
…6460)

(cherry picked from commit 4b20f25)

Co-authored-by: Hai Shi <[email protected]>

Co-authored-by: Hai Shi <[email protected]>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
[3.10] Correct the order of regen-abidump #27228
Closed
@vstinner vstinner mentioned this pull request Jun 9, 2022
[C API] Heap types (PyType_FromSpec) must fully implement the GC protocol #87138
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner
@pablogsal pablogsal Awaiting requested review from pablogsal

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@shihai1991 @miss-islington @bedevere-bot @vstinner @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.