GeezerVison

Whenever you have time, Pablo & Victor.

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 62bbb5c 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

PPC64LE Fedora Stable Refleaks PR: 2:59:32 load avg: 1.00 running: test_asyncio (2 hour 39 min), unrelated issue.

buildbot/AMD64 Windows8.1 Refleaks PR:

0:25:45 load avg: 4.38 [ 44/427/1] test_concurrent_futures failed (20 min 5 sec) -- running: test_cmd_line (25 min 44 sec), test_tools (44.7 sec), test_marshal (20 min 22 sec)
beginning 6 repetitions
123456
.....Warning -- threading_cleanup() failed to cleanup 2 threads (count: 2, dangling: 3)
Warning -- Dangling thread: <Thread(ThreadPoolExecutor-254_0, started 3616)>
Warning -- Dangling thread: <Thread(ThreadPoolExecutor-254_1, started 2112)>
Warning -- Dangling thread: <_MainThread(MainThread, started 5044)>
test test_concurrent_futures failed -- Traceback (most recent call last):
  File "D:\buildarea\pull_request.ware-win81-release.refleak\build\lib\test\test_concurrent_futures.py", line 905, in test_idle_thread_reuse
    self.assertEqual(len(executor._threads), 1)
AssertionError: 2 != 1


test_asyncio

Warning -- Unraisable exception
Traceback (most recent call last):
  File "D:\buildarea\pull_request.ware-win81-release.refleak\build\lib\asyncio\windows_events.py", line 434, in select
    self._poll(timeout)
RuntimeError: <_overlapped.Overlapped object at 0x00000022989E54E0> still has pending operation at deallocation, the process may crash


4 re-run tests:
    test_asyncio test_concurrent_futures test_ssl test_threading
Total duration: 3 hour 2 min
Tests result: FAILURE then SUCCESS

• test_threading BrokenBarrierError: https://bugs.python.org/issue11871

Thanks @erlend-aasland for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

GH-26461 is a backport of this pull request to the 3.10 branch.

@erlend-aasland: While reviewing traverse/clear functions, I noticed surprising code in pysqlite_cache_dealloc():

    if (!self->factory) {
        /* constructor failed, just get out of here */
        return;
    }

PyObject_GC_UnTrack() is not called if pysqlite_cache_init() failed, IMO it's a bug: the object is tracked in new, not in init.

Note: pysqlite_cache_init() doesn't use Py_SETREF() or Py_CLEAR() and so leaks references if called manually twice. Well, nobody should do that ;-)

While reviewing traverse/clear functions, I noticed surprising code in pysqlite_cache_dealloc():

    if (!self->factory) {
        /* constructor failed, just get out of here */
        return;
    }

PyObject_GC_UnTrack() is not called if pysqlite_cache_init() failed, IMO it's a bug: the object is tracked in new, not in init.

Note: pysqlite_cache_init() doesn't use Py_SETREF() or Py_CLEAR() and so leaks references if called manually twice. Well, nobody should do that ;-)

Yes, those are unfortunate issues :) However, they'll soon (hopefully) begone! Hint: #24203 😃 (You're welcome to take a look at that, if you find time)

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Gentoo Installed with X 3.x has failed when building commit d1124b0.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/464/builds/292) and take a look at the build logs.
4. Check if the failure is related to this commit (d1124b0) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/464/builds/292

Failed tests:

• test_idle

Failed subtests:

• test_incremental_editing - idlelib.idle_test.test_colorizer.ColorDelegatorTest

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

412 tests OK.

1 test failed:
test_idle

14 tests skipped:
test_asdl_parser test_check_c_globals test_clinic test_ctypes
test_devpoll test_gdb test_ioctl test_kqueue test_msilib
test_startfile test_winconsoleio test_winreg test_winsound
test_zipfile64

1 re-run test:
test_idle

Total duration: 26 min 43 sec

Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.installed/build/target/lib/python3.11/idlelib/idle_test/tkinter_testing_utils.py", line 54, in new_test_method
    raise exception
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.installed/build/target/lib/python3.11/idlelib/idle_test/tkinter_testing_utils.py", line 38, in after_callback
    next(test_generator)
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.installed/build/target/lib/python3.11/idlelib/idle_test/test_colorizer.py", line 573, in test_incremental_editing
    eq(text.tag_nextrange('BUILTIN', '1.0'), ('1.0', '1.3'))
AssertionError: Tuples differ: () != ('1.0', '1.3')


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.installed/build/target/lib/python3.11/idlelib/idle_test/tkinter_testing_utils.py", line 54, in new_test_method
    raise exception
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.installed/build/target/lib/python3.11/idlelib/idle_test/tkinter_testing_utils.py", line 38, in after_callback
    next(test_generator)
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.installed/build/target/lib/python3.11/idlelib/idle_test/test_colorizer.py", line 569, in test_incremental_editing
    eq(text.tag_nextrange('KEYWORD', '1.0'), ('1.0', '1.2'))
AssertionError: Tuples differ: () != ('1.0', '1.2')

Thanks for reviewing, @vstinner !