GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43795: Note Stable ABI PEP in What's New by encukou · Pull Request #26479 · python/cpython

Conversation

@encukou

@encukou encukou commented Jun 1, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue43795

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
Note Stable ABI PEP in What's New
7df555b
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 1, 2021
@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir labels Jun 1, 2021
@encukou encukou added the skip news label Jun 1, 2021
shihai1991
shihai1991 reviewed Jun 1, 2021
View reviewed changes
Comment thread Doc/whatsnew/3.10.rst
PEP 652: Maintaining the Stable ABI
-----------------------------------

The Stable ABI (Application Binary Interface) for extension modules or

@shihai1991 shihai1991 Jun 1, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. The Stable ABI and C API in here?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@encukou encukou Jun 1, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the limited C API is also defined. I went with the PEP name to make things shorter.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
shihai1991 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@encukou encukou added the needs backport to 3.10 label Jun 3, 2021
Fidget-Spinner
Fidget-Spinner approved these changes Jun 3, 2021
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one small suggestion below.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/whatsnew/3.10.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@encukou @Fidget-Spinner
Update Doc/whatsnew/3.10.rst
62b6d29 
Co-authored-by: Ken Jin <[email protected]>
@encukou
encukou merged commit 257e400 into python:main Jun 8, 2021
@miss-islington

miss-islington commented Jun 8, 2021

Copy link
Copy Markdown
Contributor

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 8, 2021
@encukou
encukou deleted the pep652-document branch June 8, 2021 15:20
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2021
@encukou @miss-islington
bpo-43795: Note Stable ABI PEP in What's New (pythonGH-26479)
ebfeaf6 
Co-authored-by: Ken Jin <[email protected]>
(cherry picked from commit 257e400)

Co-authored-by: Petr Viktorin <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Jun 8, 2021
@bedevere-bot

bedevere-bot commented Jun 8, 2021

Copy link
Copy Markdown

GH-26603 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
encukou pushed a commit that referenced this pull request Jun 8, 2021
@miss-islington
bpo-43795: Note Stable ABI PEP in What's New (GH-26479) (GH-26603)
7518556 
(cherry picked from commit 257e400)
Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: Ken Jin <[email protected]>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
[3.10] Correct the order of regen-abidump #27228
Closed
@encukou encukou mentioned this pull request Jun 7, 2022
Implement PEP 652 -- Maintaining the Stable ABI #87961
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shihai1991 shihai1991 shihai1991 left review comments
@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@encukou @miss-islington @bedevere-bot @shihai1991 @Fidget-Spinner @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.