GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-44291: Fix reconnection in logging.handlers.SysLogHandler (GH-26490) by cybergrind · Pull Request #26490 · python/cpython

Conversation

@cybergrind

@cybergrind cybergrind commented Jun 2, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue44291

./python -m test test_logging -m SysLogHandlerTest

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@cybergrind
cybergrind requested a review from vsajip as a code owner June 2, 2021 19:06
@the-knights-who-say-ni

the-knights-who-say-ni commented Jun 2, 2021

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@cybergrind

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Jun 2, 2021
@bedevere-bot bedevere-bot added the awaiting review label Jun 2, 2021
@cybergrind
cybergrind force-pushed the fix-issue-44291 branch 2 times, most recently from 59a6628 to cd61e1d Compare June 2, 2021 19:36
@the-knights-who-say-ni the-knights-who-say-ni added CLA signed and removed CLA not signed labels Jun 2, 2021
@cybergrind
cybergrind force-pushed the fix-issue-44291 branch from cd61e1d to 0af1bf5 Compare June 2, 2021 21:13
@cybergrind
cybergrind force-pushed the fix-issue-44291 branch from 0af1bf5 to 7374739 Compare June 2, 2021 23:01
@cybergrind
bpo-44291: Fix reconnection in logging.handlers.SysLogHandler (python…
4cbac84
…GH-26490)
@cybergrind
cybergrind force-pushed the fix-issue-44291 branch from 7374739 to 4cbac84 Compare June 2, 2021 23:44
@cybergrind

cybergrind commented Jun 24, 2021

Copy link
Copy Markdown
Contributor Author

Hi, @vsajip Not sure where is better to remind about PR. It would be great if you could look into it

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vsajip

vsajip commented Jun 24, 2021

Copy link
Copy Markdown
Member

Hi Kirill, sorry I haven't been able to get to it thus far. I hope to be able to review this soon - say by the middle of next week; this week I am very busy on other stuff that is more urgent. Thanks for your patience.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vsajip vsajip added the skip news label Jun 24, 2021
@vsajip

vsajip commented Aug 5, 2021

Copy link
Copy Markdown
Member

Closing and reopening to re-run stalled checks.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vsajip vsajip closed this Aug 5, 2021
@vsajip vsajip reopened this Aug 5, 2021
@vsajip vsajip changed the title bpo-44291: Fix reconnection in logging.handlers.SysLogHandler bpo-44291: Fix reconnection in logging.handlers.SysLogHandler (GH-26490) Aug 5, 2021
@vsajip
vsajip merged commit 3d315c3 into python:main Aug 5, 2021
@bedevere-bot bedevere-bot removed the awaiting review label Aug 5, 2021
@vsajip vsajip mentioned this pull request Aug 26, 2022
logging.config.dictConfig shuts down socket for existing SysLogHandlers #87362
Closed
This was referenced Oct 15, 2022
Logging: SysLogHandler.createSocket added in 3.11 but not documented #98307
Closed
gh-95913: Add WhatsNew section for new logging APIs #98320
Merged
@sahilsangani98

sahilsangani98 commented Nov 29, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Is this issue resolved with Python version 3.9 as well?

If no, how to resolve this error with Python version 3.9 as I can't upgrade my services with Python 3.11.

It will be really appreciated if someone can guide me on this.

@cybergrind
@vsajip
@alex

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vsajip

vsajip commented Nov 30, 2022

Copy link
Copy Markdown
Member

Simplest: Why not copy the handler from 3.11 to your own code and use that?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@cybergrind @the-knights-who-say-ni @vsajip @sahilsangani98 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.