GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-28556: Update to typing: treat subscripted generics as proxies by ilevkivskyi · Pull Request #265 · python/cpython

Conversation

@ilevkivskyi

@ilevkivskyi ilevkivskyi commented Feb 23, 2017

Copy link
Copy Markdown
Member

This a recent update from python/typing repo. See python/typing#393 for details.

This needs to be backported to 3.5 and 3.6

@ned-deily Guido would like to get this into 3.6.1

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ilevkivskyi
Update to typing: treat subsctipted generics as proxies
455dc83
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 23, 2017
@ilevkivskyi ilevkivskyi mentioned this pull request Feb 23, 2017
Treat subscripted generics as "proxies" for original class. python/typing#393
Merged
@ilevkivskyi ilevkivskyi changed the title bpo-28556: Update to typing: treat subsctipted generics as proxies bpo-28556: Update to typing: treat subscripted generics as proxies Feb 23, 2017
@Mariatta Mariatta added needs backport to 3.5 labels Feb 24, 2017
Mariatta
Mariatta approved these changes Feb 24, 2017
View reviewed changes
@Mariatta
Mariatta merged commit abb3b8a into python:master Feb 24, 2017
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Feb 24, 2017
@ilevkivskyi @Mariatta
Update to typing: treat subscripted generics as proxies (python#265)
a59a380
(cherry picked from commit abb3b8a)
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Feb 24, 2017
@ilevkivskyi @Mariatta
Update to typing: treat subscripted generics as proxies (python#265)
2ad381f
(cherry picked from commit abb3b8a)
@Mariatta Mariatta removed needs backport to 3.5 labels Feb 24, 2017
@ilevkivskyi

ilevkivskyi commented Feb 24, 2017

Copy link
Copy Markdown
Member Author

@Mariatta Thank you for taking care of this!

Unfortunately, this PR introduced a small bug, that I spotted just now. I have made an additional PR #270 that fixes it. Sorry for troubles!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Mariatta

Mariatta commented Feb 24, 2017

Copy link
Copy Markdown
Member

Thanks @ilevkivskyi :) I cherry-picked this into the existing PRs
See GH-269 for the 3.5 backport and GH-268 for 3.6 backport.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ilevkivskyi

ilevkivskyi commented Feb 24, 2017

Copy link
Copy Markdown
Member Author

Thanks @ilevkivskyi :) I cherry-picked this into the existing PRs
See GH-269 for the 3.5 backport and GH-268 for 3.6 backport.

Thank you Mariatta, this is perfect.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ilevkivskyi
ilevkivskyi deleted the update-typing-proxy branch February 24, 2017 19:51
Mariatta added a commit that referenced this pull request Feb 25, 2017
@Mariatta
[3.6] bpo-28556: Update to typing: treat subscripted generics as prox…
bea9d2f
…ies (GH-265) (GH-268)

(cherry picked from commit abb3b8a)
(cherry picked from commit 365cb5b)
Mariatta added a commit that referenced this pull request Feb 25, 2017
@Mariatta
[3.5] bpo-28556: Update to typing: treat subscripted generics as prox…
bc33cd4
…ies (GH-265) (GH-269)

(cherry picked from commit abb3b8a)
(cherry picked from commit 365cb5b)
akruis added a commit to akruis/cpython that referenced this pull request Jun 9, 2021
@akruis
Stackless issue python#265: fix PyChannel_Send_M
32b481f
The implementation was buggy. This affects only users of the C-API,
that call PyChannel_Send() and PyChannel_Send_nr() for calls from
outside of the interpreter (with no main-tasklet).
akruis added a commit to akruis/cpython that referenced this pull request Jun 9, 2021
@akruis
Stackless issue python#265: fix PyChannel_Receive_M and tasklet_new
235fc6f
If called from outside of the interpreter the behavior was undefined.
(Calling a C-function with wrong number of arguments).
akruis added a commit to akruis/cpython that referenced this pull request Jun 9, 2021
@akruis
Stackless issue python#265: fix __reduce__ / __reduce_ex__
233e873
Avoid undefined behavior, if Stackless classes implement __reduce__()
and __reduce_ex__() using a single C-function.
__reduce_ex__ now checks the type of its argument.
akruis added a commit to akruis/cpython that referenced this pull request Jun 9, 2021
@akruis
Stackless issue python#265: fix the signature of tp_clear functions
d822483
Return type is 'int', not 'void'.
akruis added a commit to akruis/cpython that referenced this pull request Jun 9, 2021
@akruis
Stackless issue python#265: add missing arguments to C-function defin…
b62a6fe
…itions

Most (getter)-functions, (setter)-functions and (PyCFunction)-functions
with flag METH_NOARGS lack an unused last argument, "void *" for
(getter) and (setter), "PyObject *" for (PyCFunction)-functions.
This commit adds these arguments.
akruis added a commit to akruis/cpython that referenced this pull request Jun 9, 2021
@akruis
Stackless issue python#265: add missing arguments to C-function defin…
696b1ef
…itions

Most (getter)-functions, (setter)-functions and (PyCFunction)-functions
with flag METH_NOARGS lack an unused last argument, "void *" for
(getter) and (setter), "PyObject *" for (PyCFunction)-functions.
This commit adds these arguments.
akruis added a commit to akruis/cpython that referenced this pull request Jun 11, 2021
@akruis
Stackless issue python#265: fix PyChannel_Send_M
3f54aa5
The implementation was buggy. This affects only users of the C-API,
that call PyChannel_Send() and PyChannel_Send_nr() for calls from
outside of the interpreter (with no main-tasklet).
akruis added a commit to akruis/cpython that referenced this pull request Jun 11, 2021
@akruis
Stackless issue python#265: fix PyChannel_Receive_M and tasklet_new
04cff9c
If called from outside of the interpreter the behavior was undefined.
(Calling a C-function with wrong number of arguments).
akruis added a commit to akruis/cpython that referenced this pull request Jun 11, 2021
@akruis
Stackless issue python#265: fix __reduce__ / __reduce_ex__
10c8679
Avoid undefined behavior, if Stackless classes implement __reduce__()
and __reduce_ex__() using a single C-function.
__reduce_ex__ now checks the type of its argument.
akruis added a commit to akruis/cpython that referenced this pull request Jun 11, 2021
@akruis
Stackless issue python#265: fix the signature of tp_clear functions
f3739b9
Return type is 'int', not 'void'.
akruis added a commit to akruis/cpython that referenced this pull request Jun 11, 2021
@akruis
Stackless issue python#265: add missing arguments to C-function defin…
cd48a58
…itions

Most (getter)-functions, (setter)-functions and (PyCFunction)-functions
with flag METH_NOARGS lack an unused last argument, "void *" for
(getter) and (setter), "PyObject *" for (PyCFunction)-functions.
This commit adds these arguments.
akruis added a commit to akruis/cpython that referenced this pull request Jun 11, 2021
@akruis
Stackless issue python#265: Fix invalid function cast warnings
ba14f05
Fix invalid function cast warnings with gcc 8 for method conventions
different from METH_NOARGS, METH_O and METH_VARARGS excluding Argument
Clinic generated code.
akruis added a commit to akruis/cpython that referenced this pull request Jun 11, 2021
@akruis
Stackless issue python#265: Fix (invalid) function cast warnings with…
b73166e
… gcc 8

* fix PyChannel_Send_M

The implementation was buggy. This affects only users of the C-API,
that call PyChannel_Send() and PyChannel_Send_nr() for calls from
outside of the interpreter (with no main-tasklet).

* fix PyChannel_Receive_M and tasklet_new

If called from outside of the interpreter the behavior was undefined.
(Calling a C-function with wrong number of arguments).

* fix __reduce__ / __reduce_ex__

Avoid undefined behavior, if Stackless classes implement __reduce__()
and __reduce_ex__() using a single C-function.
__reduce_ex__ now checks the type of its argument.

* fix the signature of tp_clear functions

Return type is 'int', not 'void'.

* add missing arguments to C-function definitions

Most (getter)-functions, (setter)-functions and (PyCFunction)-functions
with flag METH_NOARGS lack an unused last argument, "void *" for
(getter) and (setter), "PyObject *" for (PyCFunction)-functions.
This commit adds these arguments.

* Fix invalid function cast warnings

Fix invalid function cast warnings with gcc 8 for method conventions
different from METH_NOARGS, METH_O and METH_VARARGS excluding Argument
Clinic generated code.
akruis added a commit to akruis/cpython that referenced this pull request Jun 11, 2021
@akruis
Stackless issue python#265: merge changelog entries for this issue
4f89f4a
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@dependabot-preview
Bump redis from 3.3.7 to 3.3.8 (#265)
2235de7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mariatta Mariatta Mariatta approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ilevkivskyi @Mariatta @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.