GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-44298: Fix line numbers for early exits in with statements. by markshannon · Pull Request #26513 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Jun 3, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue44298

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon
Fix line numbers for early exits in with statements.
5de42ab
@markshannon markshannon added the skip news label Jun 3, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 3, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Jun 3, 2021
@markshannon
Regen importlib
07b0702
@markshannon
markshannon merged commit 937cebc into python:main Jun 3, 2021
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 3, 2021
@markshannon markshannon added the needs backport to 3.10 label Jun 3, 2021
@miss-islington

miss-islington commented Jun 3, 2021

Copy link
Copy Markdown
Contributor

Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jun 3, 2021

Copy link
Copy Markdown
Contributor

Sorry, @markshannon, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 937cebc93b4922583218e0cbf0a9a14705a595b2 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned markshannon Jun 3, 2021
pablogsal pushed a commit that referenced this pull request Jun 3, 2021
@markshannon
[3.10] bpo-44298: Backport #26513 to 3.10 (#26516)
cea0585 
* Backport 937cebc to 3.10

* Update importlib
@markshannon
markshannon deleted the fix-lineno-early-exit-with branch June 4, 2021 10:49
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
[3.10] Correct the order of regen-abidump #27228
Closed
@nedbat nedbat mentioned this pull request Jun 20, 2022
3.10.0b2 traces with-exit before the break that caused the exit #88464
Closed
@ZeroIntensity ZeroIntensity removed the needs backport to 3.10 label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@markshannon markshannon

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@markshannon @miss-islington @the-knights-who-say-ni @bedevere-bot @ZeroIntensity
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.