GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43693: Un-revert commits 2c1e258 and b2bf2bc. by ericsnowcurrently · Pull Request #26577 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Jun 7, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

These were reverted in gh-26530 (commit 17c4edc) due to refleaks.

  • 2c1e258 - Compute deref offsets in compiler (bpo-43693: Compute deref offsets in compiler #25152)
  • b2bf2bc - Add new internal code objects fields: co_fastlocalnames and co_fastlocalkinds. (bpo-43693: Add new internal code objects fields: co_fastlocalnames and co_fastlocalkinds. #26388)

This PR fixes the refleaks. (@pablogsal, I'm running it through the buildbots before merging this time.)

https://bugs.python.org/issue43693

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ericsnowcurrently
ericsnowcurrently requested review from markshannon and tiran as code owners June 7, 2021 15:23
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 7, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Jun 7, 2021
@ericsnowcurrently
ericsnowcurrently removed the request for review from tiran June 7, 2021 15:24
@ericsnowcurrently ericsnowcurrently added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 7, 2021
@bedevere-bot

bedevere-bot commented Jun 7, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 4eb1135e930dcea94483d350ac5ed92ee07f22ae 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 7, 2021
@pablogsal

pablogsal commented Jun 7, 2021

Copy link
Copy Markdown
Member

This PR fixes the refleaks. (@pablogsal, I'm running it through the buildbots before merging this time.)

Thanks a lot @ericsnowcurrently ❤️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ericsnowcurrently added 2 commits June 7, 2021 12:03
@ericsnowcurrently
Un-revert commits 2c1e258 and b2bf2bc.
5e98b69 
These were reverted in pythonGH-26530 (commit 17c4edc).

* Compute deref offsets in compiler (pythongh-25152)
* Add new internal code objects fields: co_fastlocalnames and co_fastlocalkinds. (pythongh-26388)
@ericsnowcurrently
Fix refleaks.
1fb813c
@ericsnowcurrently
ericsnowcurrently force-pushed the unrevert-localsplusnames branch from 4eb1135 to 1fb813c Compare June 7, 2021 18:04
@ericsnowcurrently

ericsnowcurrently commented Jun 7, 2021

Copy link
Copy Markdown
Member Author

The buildbots say "the refleaks have been fixed". 🙂
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently
ericsnowcurrently merged commit 2ab27c4 into python:main Jun 7, 2021
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 7, 2021
@ericsnowcurrently
ericsnowcurrently deleted the unrevert-localsplusnames branch June 7, 2021 18:22
@markshannon markshannon mentioned this pull request May 2, 2022
Logically merge cell and locals array. They are already contiguous in memory #87859
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ericsnowcurrently @bedevere-bot @pablogsal @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.