GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43693: Revert commits 2c1e2583fdc4db6b43d163239ea42b0e8394171f and b2bf2bc1ece673d387341e06c8d3c2bc6e259747 by pablogsal · Pull Request #26530 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Jun 4, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue43693

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
pablogsal added 2 commits June 4, 2021 17:31
@pablogsal
Revert "bpo-43693: Compute deref offsets in compiler (pythongh-25152)"
5e5dd48 
This reverts commit b2bf2bc.
@pablogsal
Revert "bpo-43693: Add new internal code objects fields: co_fastlocal…
9b5f708 
…names and co_fastlocalkinds. (pythongh-26388)"

This reverts commit 2c1e258.
@pablogsal
pablogsal requested review from ericsnowcurrently and markshannon June 4, 2021 16:32
@pablogsal
pablogsal requested a review from tiran as a code owner June 4, 2021 16:32
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 4, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Jun 4, 2021
@pablogsal

pablogsal commented Jun 4, 2021

Copy link
Copy Markdown
Member Author

The leaks are fixed after the revert:

❯ ./python -m test test_code -R :
0:00:00 load avg: 5.88 Run tests sequentially
0:00:00 load avg: 5.88 [1/1] test_code
beginning 9 repetitions
123456789
.........

== Tests result: SUCCESS ==

1 test OK.

Total duration: 709 ms
Tests result: SUCCESS

master on  main [$?⇡]  pyenv 3.9.1
❯ ./python  -m test test_exceptions -R :
0:00:00 load avg: 5.88 Run tests sequentially
0:00:00 load avg: 5.88 [1/1] test_exceptions
beginning 9 repetitions
123456789
.........

== Tests result: SUCCESS ==

1 test OK.

Total duration: 21.7 sec
Tests result: SUCCESS
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal merged commit 17c4edc into python:main Jun 4, 2021
@pablogsal
pablogsal deleted the revert-bpo-43693 branch June 4, 2021 16:51
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 4, 2021
@ericsnowcurrently ericsnowcurrently mentioned this pull request Jun 7, 2021
bpo-43693: Un-revert commits 2c1e258 and b2bf2bc. #26577
Merged
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request Jun 7, 2021
@ericsnowcurrently
Un-revert commits 2c1e258 and b2bf2bc.
5e98b69 
These were reverted in pythonGH-26530 (commit 17c4edc).

* Compute deref offsets in compiler (pythongh-25152)
* Add new internal code objects fields: co_fastlocalnames and co_fastlocalkinds. (pythongh-26388)
ericsnowcurrently added a commit that referenced this pull request Jun 7, 2021
@ericsnowcurrently
bpo-43693: Un-revert commits 2c1e258 and b2bf2bc. (gh-26577)
2ab27c4 
These were reverted in gh-26530 (commit 17c4edc) due to refleaks.

* 2c1e258 - Compute deref offsets in compiler (gh-25152)
* b2bf2bc - Add new internal code objects fields: co_fastlocalnames and co_fastlocalkinds. (gh-26388)

This change fixes the refleaks.

https://bugs.python.org/issue43693
@markshannon markshannon mentioned this pull request May 2, 2022
Logically merge cell and locals array. They are already contiguous in memory #87859
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@tiran tiran Awaiting requested review from tiran

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@pablogsal @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.