GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert "bpo-43693: Add the MAKE_CELL opcode and interleave fast locals offsets. (gh-26396)" by pablogsal · Pull Request #26597 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Jun 8, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This reverts commit 631f993 as it has broken the ASAN buildbots:

https://buildbot.python.org/all/#/builders/585

https://bugs.python.org/issue43693

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@pablogsal
Revert "bpo-43693: Add the MAKE_CELL opcode and interleave fast local…
01ff3e0
…s offsets. (pythongh-26396)"

This reverts commit 631f993.
@pablogsal
pablogsal requested a review from markshannon as a code owner June 8, 2021 11:11
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 8, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Jun 8, 2021
@pablogsal

pablogsal commented Jun 8, 2021

Copy link
Copy Markdown
Member Author

CC: @ericsnowcurrently @markshannon I have tried to find the error myself and debug this issue for 30 min, but the patch in 631f993 is quite involved and I need to catch up with the rest of changes made to the compiler so I was not able to find it quickly :(

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal

pablogsal commented Jun 8, 2021

Copy link
Copy Markdown
Member Author

The problem is that PyFrame_LocalsToFast(frame, 1); calls into PyFrame_LocalsToFast where co->co_nlocals has a value of 3, and this causes co->co_cell2arg[i - co->co_nlocals]; to access outside the bounds of the array.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 8, 2021
@bedevere-bot

bedevere-bot commented Jun 8, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 01ff3e0 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 8, 2021
@pablogsal
pablogsal merged commit 3fe921c into python:main Jun 8, 2021
@pablogsal
pablogsal deleted the bpo-43693 branch June 8, 2021 12:17
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 8, 2021
@ericsnowcurrently

ericsnowcurrently commented Jun 8, 2021

Copy link
Copy Markdown
Member

@pablogsal, sorry to impose again! I was watching the buildbots after but ran out of time to wait for them all to finish. Lesson learned.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal

pablogsal commented Jun 8, 2021

Copy link
Copy Markdown
Member Author

@pablogsal, sorry to impose again! I was watching the buildbots after but ran out of time to wait for them all to finish. Lesson learned.

No problem! I will try to improve the experience a bit better if I managed to find the time. Will try to propose some improvements so maybe the failures are reported in a comment or something

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ericsnowcurrently

ericsnowcurrently commented Jun 8, 2021

Copy link
Copy Markdown
Member

What's the best way for me to run the address sanitizer locally, to reproduce the failure?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ericsnowcurrently

ericsnowcurrently commented Jun 8, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

...and thanks for the helpful analysis above.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal

pablogsal commented Jun 8, 2021

Copy link
Copy Markdown
Member Author

What's the best way for me to run the address sanitizer locally, to reproduce the failure?

I mentioned it in https://bugs.python.org/msg395321 but I should have mentioned it here as well:

$ export ASAN_OPTIONS=detect_leaks=0:allocator_may_return_null=1:handle_segv=0
$ ./configure --with-address-sanitizer --without-pymalloc
$ make -j -s
$ ./python -m test test_sys_settrace
ericsnowcurrently reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal

pablogsal commented Jun 8, 2021

Copy link
Copy Markdown
Member Author

I used gcc 10 for this, but I think clang works as well as any recent version of gcc.

ericsnowcurrently reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal

pablogsal commented Jun 8, 2021

Copy link
Copy Markdown
Member Author

giphy (1)

ericsnowcurrently reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request Jun 8, 2021
@ericsnowcurrently
Un-revert "bpo-43693: Add the MAKE_CELL opcode and interleave fast lo…
ddcfb69
…cals offsets. (pythongh-26396)"

That commit (3fe921c) was reverted in pythonGH-26597
(3fe921c).
@markshannon markshannon mentioned this pull request May 2, 2022
Logically merge cell and locals array. They are already contiguous in memory #87859
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@pablogsal @bedevere-bot @ericsnowcurrently @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.