GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43693: Do not check co_cell2arg if a non-cell offset. by ericsnowcurrently · Pull Request #26626 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Jun 9, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is the same fix as for PyFrame_LocalsToFast() in gh-26609, but applied to PyFrame_FastToLocalsWithError(). (It should have been in that PR.)

https://bugs.python.org/issue43693

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gvanrossum reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@ericsnowcurrently
Do not check co_cell2arg if a non-cell offset.
75ee495
@ericsnowcurrently ericsnowcurrently added the skip news label Jun 9, 2021
@ericsnowcurrently
ericsnowcurrently requested a review from markshannon June 9, 2021 17:21
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 9, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Jun 9, 2021
@markshannon markshannon mentioned this pull request Jun 9, 2021
bpo-44337: Port LOAD_ATTR to PEP 659 adaptive interpreter #26595
Merged
@ericsnowcurrently
ericsnowcurrently merged commit e6e34e4 into python:main Jun 9, 2021
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 9, 2021
@ericsnowcurrently
ericsnowcurrently deleted the fix-address-sanitizer branch June 9, 2021 17:41
@markshannon

markshannon commented Jun 9, 2021

Copy link
Copy Markdown
Member

@ericsnowcurrently have you run the tests with the address sanitizer on this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently

ericsnowcurrently commented Jun 9, 2021

Copy link
Copy Markdown
Member Author

@markshannon, I did not. However, I figured this would take care of the problem and the buildbot results for the merge indicate it did.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon markshannon mentioned this pull request May 2, 2022
Logically merge cell and locals array. They are already contiguous in memory #87859
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ericsnowcurrently @markshannon @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.