GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43693: Un-revert commit f3fa63e. by ericsnowcurrently · Pull Request #26609 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Jun 8, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This was reverted in GH-26596 (commit 6d518bb) due to some bad memory accesses.

  • Add the MAKE_CELL opcode. (bpo-43693: Add the MAKE_CELL opcode and interleave fast locals offsets. #26396)

The memory accesses have been fixed and I verified the address sanitizer is happy now (after duplicating the failure locally).

https://bugs.python.org/issue43693

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 3 commits June 8, 2021 08:34
@ericsnowcurrently
Un-revert "bpo-43693: Add the MAKE_CELL opcode and interleave fast lo…
ddcfb69 
…cals offsets. (pythongh-26396)"

That commit (3fe921c) was reverted in pythonGH-26597
(3fe921c).
@ericsnowcurrently
Fix a comment.
969212a
@ericsnowcurrently
Do not check co_cell2arg if a free var.
5107da7
@ericsnowcurrently
ericsnowcurrently requested a review from pablogsal June 8, 2021 18:39
@ericsnowcurrently
ericsnowcurrently requested a review from markshannon as a code owner June 8, 2021 18:39
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 8, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Jun 8, 2021
@ericsnowcurrently ericsnowcurrently added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 8, 2021
@bedevere-bot

bedevere-bot commented Jun 8, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 5107da7 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 8, 2021
pablogsal
pablogsal approved these changes Jun 8, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 8, 2021
@pablogsal

pablogsal commented Jun 8, 2021

Copy link
Copy Markdown
Member

Thanks for the quick fix, @ericsnowcurrently
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently
ericsnowcurrently removed the request for review from markshannon June 8, 2021 20:13
@ericsnowcurrently
ericsnowcurrently merged commit 3e1c716 into python:main Jun 8, 2021
@bedevere-bot

bedevere-bot commented Jun 8, 2021

Copy link
Copy Markdown

@ericsnowcurrently: Please replace # with GH- in the commit message next time. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 8, 2021
@ericsnowcurrently
ericsnowcurrently deleted the unrevert-add-make-cell branch June 8, 2021 22:01
@ericsnowcurrently ericsnowcurrently mentioned this pull request Jun 9, 2021
bpo-43693: Do not check co_cell2arg if a non-cell offset. #26626
Merged
ericsnowcurrently added a commit that referenced this pull request Jun 9, 2021
@ericsnowcurrently
bpo-43693: Do not check co_cell2arg if a non-cell offset. (gh-26626)
e6e34e4 
This is the same fix as for PyFrame_LocalsToFast() in gh-26609, but applied to PyFrame_FastToLocalsWithError(). (It should have been in that PR.)

https://bugs.python.org/issue43693
@markshannon markshannon mentioned this pull request May 2, 2022
Logically merge cell and locals array. They are already contiguous in memory #87859
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ericsnowcurrently @bedevere-bot @pablogsal @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.