GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] bpo-44368: Ensure we don't raise incorrect custom syntax errors with soft keywords (GH-26630) by miss-islington · Pull Request #26631 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 9, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 457ce60)

Co-authored-by: Pablo Galindo [email protected]

https://bugs.python.org/issue44368

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal @miss-islington
bpo-44368: Ensure we don't raise incorrect custom syntax errors with …
1792260 
…soft keywords (pythonGH-26630)

(cherry picked from commit 457ce60)

Co-authored-by: Pablo Galindo <[email protected]>
@miss-islington
miss-islington requested review from lysnikolaou and pablogsal as code owners June 9, 2021 21:20
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 9, 2021
@miss-islington

miss-islington commented Jun 9, 2021

Copy link
Copy Markdown
Contributor Author

@pablogsal: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot mentioned this pull request Jun 9, 2021
bpo-44368: Ensure we don't raise incorrect custom syntax errors with soft keywords #26630
Merged
@miss-islington

miss-islington commented Jun 9, 2021

Copy link
Copy Markdown
Contributor Author

@pablogsal: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added skip news awaiting review labels Jun 9, 2021
pablogsal
pablogsal approved these changes Jun 9, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 9, 2021
@miss-islington

miss-islington commented Jun 9, 2021

Copy link
Copy Markdown
Contributor Author

@pablogsal: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit f807a4f into python:3.10 Jun 9, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 9, 2021
@miss-islington
miss-islington deleted the backport-457ce60-3.10 branch June 9, 2021 21:45
@brandtbucher brandtbucher mentioned this pull request May 9, 2023
Invalid mapping patterns give confusing SyntaxErrors #88534
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @pablogsal @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.