GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-44368: Ensure we don't raise incorrect custom syntax errors with soft keywords by pablogsal · Pull Request #26630 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Jun 9, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue44368

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
pablogsal requested a review from lysnikolaou as a code owner June 9, 2021 20:42
@pablogsal pablogsal added needs backport to 3.10 skip news labels Jun 9, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 9, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Jun 9, 2021
@pablogsal
pablogsal force-pushed the bpo-44368 branch 2 times, most recently from 6ec8cd1 to 8a7611d Compare June 9, 2021 20:44
@pablogsal
bpo-44368: Ensure we don't raise incorrect custom syntax errors with …
e125d89 
…soft keywords
@pablogsal
pablogsal force-pushed the bpo-44368 branch from 8a7611d to e125d89 Compare June 9, 2021 20:58
@pablogsal
pablogsal merged commit 457ce60 into python:main Jun 9, 2021
@pablogsal
pablogsal deleted the bpo-44368 branch June 9, 2021 21:20
@miss-islington

miss-islington commented Jun 9, 2021

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 9, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 9, 2021
@pablogsal @miss-islington
bpo-44368: Ensure we don't raise incorrect custom syntax errors with …
1792260 
…soft keywords (pythonGH-26630)

(cherry picked from commit 457ce60)

Co-authored-by: Pablo Galindo <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 9, 2021

Copy link
Copy Markdown

GH-26631 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Jun 9, 2021
miss-islington added a commit that referenced this pull request Jun 9, 2021
@miss-islington @pablogsal
bpo-44368: Ensure we don't raise incorrect custom syntax errors with …
f807a4f 
…soft keywords (GH-26630)

(cherry picked from commit 457ce60)

Co-authored-by: Pablo Galindo <[email protected]>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
[3.10] Correct the order of regen-abidump #27228
Closed
@brandtbucher brandtbucher mentioned this pull request May 9, 2023
Invalid mapping patterns give confusing SyntaxErrors #88534
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@pablogsal @miss-islington @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.