GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] bpo-43795: Don't list private names in the limited API (GH-26740) by miss-islington · Pull Request #26753 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 16, 2021 •
edited by encukou
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Use the public alias PyFrameObject rather than _frame
  • Remove _node, which disappeared in 3.9 along with the old parser
  • Ensure private (underscore-prefixed) names are not on the Limited API list. (They can be part of the stable ABI, though, e.g. as implementation details of macros.)

(cherry picked from commit 7cad9cb)

Co-authored-by: Petr Viktorin [email protected]

https://bugs.python.org/issue43795

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@encukou @miss-islington
bpo-43795: Don't list private names in the limited API (pythonGH-26740)
95404e2
* Remove struct _node from the stable ABI list

This struct was removed along with the old parser in Python 3.9 (PEP 617)

* Stable ABI list: Use the public name "PyFrameObject" rather than "_frame"

* Ensure limited API doesn't contain private names

Names prefixed by an underscore are private by definition.

* Add a blurb
(cherry picked from commit 7cad9cb)

Co-authored-by: Petr Viktorin <[email protected]>
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 16, 2021
@bedevere-bot bedevere-bot mentioned this pull request Jun 16, 2021
bpo-43795: Don't list private names in the limited API #26740
Merged
@miss-islington

miss-islington commented Jun 16, 2021

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added the awaiting review label Jun 16, 2021
@miss-islington

miss-islington commented Jun 16, 2021

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@encukou

encukou commented Jun 16, 2021

Copy link
Copy Markdown
Member

cc @pablogsal – stable ABI doc fix & additional check

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington

miss-islington commented Jun 16, 2021

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pablogsal
pablogsal approved these changes Jun 16, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 16, 2021
@miss-islington
miss-islington merged commit 7fd4010 into python:3.10 Jun 16, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 16, 2021
@miss-islington
miss-islington deleted the backport-7cad9cb-3.10 branch June 16, 2021 09:53
@encukou encukou mentioned this pull request Jun 7, 2022
Implement PEP 652 -- Maintaining the Stable ABI #87961
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @encukou @pablogsal @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.