GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43795: Don't list private names in the limited API by encukou · Pull Request #26740 · python/cpython

Conversation

@encukou

@encukou encukou commented Jun 15, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Use the public alias PyFrameObject rather than _frame
  • Remove _node, which disappeared in 3.9 along with the old parser
  • Ensure private (underscore-prefixed) names are not on the Limited API list. (They can be part of the stable ABI, though, e.g. as implementation details of macros.)

This only affects documentation.

https://bugs.python.org/issue43795

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
encukou added 4 commits June 15, 2021 16:41
@encukou
Remove struct _node from the stable ABI list
76e0f3f 
This struct was removed along with the old parser in Python 3.9 (PEP 617)
@encukou
Stable ABI list: Use the public name "PyFrameObject" rather than "_fr…
1f57ce9 
…ame"
@encukou
Ensure limited API doesn't contain private names
747ac56 
Names prefixed by an underscore are private by definition.
@encukou
Add a blurb
917b745
@encukou encukou added the needs backport to 3.10 label Jun 15, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 15, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Jun 15, 2021
erlend-aasland
erlend-aasland approved these changes Jun 15, 2021
View reviewed changes
@encukou
encukou merged commit 7cad9cb into python:main Jun 16, 2021
@miss-islington

miss-islington commented Jun 16, 2021

Copy link
Copy Markdown
Contributor

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 16, 2021
@encukou
encukou deleted the pep652-privatenamed-structs branch June 16, 2021 09:22
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 16, 2021
@encukou @miss-islington
bpo-43795: Don't list private names in the limited API (pythonGH-26740)
95404e2 
* Remove struct _node from the stable ABI list

This struct was removed along with the old parser in Python 3.9 (PEP 617)

* Stable ABI list: Use the public name "PyFrameObject" rather than "_frame"

* Ensure limited API doesn't contain private names

Names prefixed by an underscore are private by definition.

* Add a blurb
(cherry picked from commit 7cad9cb)

Co-authored-by: Petr Viktorin <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Jun 16, 2021
@bedevere-bot

bedevere-bot commented Jun 16, 2021

Copy link
Copy Markdown

GH-26753 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request Jun 16, 2021
@miss-islington @encukou
bpo-43795: Don't list private names in the limited API (GH-26740)
7fd4010 
* Remove struct _node from the stable ABI list

This struct was removed along with the old parser in Python 3.9 (PEP 617)

* Stable ABI list: Use the public name "PyFrameObject" rather than "_frame"

* Ensure limited API doesn't contain private names

Names prefixed by an underscore are private by definition.

* Add a blurb
(cherry picked from commit 7cad9cb)

Co-authored-by: Petr Viktorin <[email protected]>
jdevries3133 pushed a commit to jdevries3133/cpython that referenced this pull request Jun 19, 2021
@encukou @jdevries3133
bpo-43795: Don't list private names in the limited API (pythonGH-26740)
b7f3aca 
* Remove struct _node from the stable ABI list

This struct was removed along with the old parser in Python 3.9 (PEP 617)

* Stable ABI list: Use the public name "PyFrameObject" rather than "_frame"

* Ensure limited API doesn't contain private names

Names prefixed by an underscore are private by definition.

* Add a blurb
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
[3.10] Correct the order of regen-abidump #27228
Closed
@encukou encukou mentioned this pull request Jun 7, 2022
Implement PEP 652 -- Maintaining the Stable ABI #87961
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@encukou @miss-islington @bedevere-bot @erlend-aasland @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.