GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43693 Get rid of CO_NOFREE -- it's unused by gvanrossum · Pull Request #26839 · python/cpython

Conversation

@gvanrossum

@gvanrossum gvanrossum commented Jun 21, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

All uses of this flag are either setting it or in doc or tests for it. So we should be able to get rid of it completely.

https://bugs.python.org/issue43693

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gvanrossum
Get rid of CO_NOFREE -- it's unused
3abad5f 
All uses of this flag are either setting it
or in doc or tests for it. So we should be
able to get rid of it completely.
@gvanrossum gvanrossum added the skip news label Jun 21, 2021
@gvanrossum
gvanrossum requested a review from markshannon as a code owner June 21, 2021 22:30
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 21, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Jun 21, 2021
gvanrossum added 3 commits June 21, 2021 16:00
@gvanrossum
Generate some more files (test_frozenmain.h, frozen_hello.h)
abd143c 
These aren't automatically generated on Windows. :-(
@gvanrossum
Fix test_code.py
c567c53
@gvanrossum
Fix test_dis.py
19a494f
@gvanrossum
gvanrossum requested a review from ericsnowcurrently June 23, 2021 00:41
@markshannon

markshannon commented Jun 23, 2021

Copy link
Copy Markdown
Member

I see you've skipped the news item. I've made https://bugs.python.org/issue44500 to remind us to document all these changes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
markshannon
markshannon approved these changes Jun 23, 2021
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 23, 2021
@gvanrossum
gvanrossum merged commit 769d7d0 into python:main Jun 23, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 23, 2021
@gvanrossum
gvanrossum deleted the drop-nofree-flag branch June 23, 2021 16:51
@markshannon markshannon mentioned this pull request May 2, 2022
Logically merge cell and locals array. They are already contiguous in memory #87859
Closed
2elli added a commit to 2elli/python-xdis that referenced this pull request Aug 15, 2023
@2elli
remove NOFREE flag in code info test
dfcf1ad 
Python 3.11 removes this flag, see python/cpython#26839
2elli added a commit to 2elli/python-xdis that referenced this pull request Aug 15, 2023
@2elli
remove use of NOFREE flag when testing >= 3.11
06299f3 
Python 3.11 removes this flag, see python/cpython#26839
encukou added a commit to encukou/cpython that referenced this pull request Oct 15, 2026
@encukou
pythongh-68656: Pass CO_* constants for inspect from C; deprecate CO_…
92a31f4 
…NOFREE

The constants were redefined in dis.py, and not perfectly kept in
sync: inspect.CO_NOFREE was kept even though the C define went away
in pythongh-26839.

- Expose the constants via `_opcode` (as agreed in pythongh-68656)
  and its wrapper `opcode`.
  This removes `CO_NOFREE` from `dis.COMPILER_FLAG_NAMES`.
- Re-add, deprecate and document inspect.CO_NOFREE
encukou added a commit to encukou/cpython that referenced this pull request Oct 15, 2026
@encukou
pythongh-68656: Pass CO_* constants for inspect from C; deprecate CO_…
4db80fe 
…NOFREE

The constants were redefined in dis.py, and not perfectly kept in
sync: inspect.CO_NOFREE was kept even though the C define went away
in pythongh-26839.

- Expose the constants via `_opcode` (as agreed in pythongh-68656)
  and its wrapper `opcode`.
  This removes `CO_NOFREE` from `dis.COMPILER_FLAG_NAMES`.
- Re-add, deprecate and document inspect.CO_NOFREE
@encukou encukou mentioned this pull request Oct 15, 2026
gh-68656: Pass CO_* constants for inspect from C; deprecate CO_NOFREE #159461
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@gvanrossum @markshannon @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.