GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] bpo-44439: BZ2File.write() / LZMAFile.write() handle buffer protocol correctly (GH-26764) by miss-islington · Pull Request #26845 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 22, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

No longer use len() to get the length of the input data. For some buffer protocol objects,
the length obtained by using len() is wrong.
(cherry picked from commit bc6c12c)

Co-authored-by: Ma Lin [email protected]

https://bugs.python.org/issue44439

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@miss-islington
bpo-44439: BZ2File.write() / LZMAFile.write() handle buffer protocol …
559d927 
…correctly (pythonGH-26764)

No longer use len() to get the length of the input data. For some buffer protocol objects,
the length obtained by using len() is wrong.
(cherry picked from commit bc6c12c)

Co-authored-by: Ma Lin <[email protected]>
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 22, 2021
@miss-islington

miss-islington commented Jun 22, 2021

Copy link
Copy Markdown
Contributor Author

@animalize and @serhiy-storchaka: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot mentioned this pull request Jun 22, 2021
bpo-44439: BZ2File.write() / LZMAFile.write() handle buffer protocol correctly #26764
Merged
@miss-islington

miss-islington commented Jun 22, 2021

Copy link
Copy Markdown
Contributor Author

@animalize and @serhiy-storchaka: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label Jun 22, 2021
serhiy-storchaka
serhiy-storchaka approved these changes Jun 22, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 22, 2021
@serhiy-storchaka
serhiy-storchaka merged commit 01858fb into python:3.10 Jun 22, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 22, 2021
@miss-islington
miss-islington deleted the backport-bc6c12c-3.10 branch June 22, 2021 14:00
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
[3.10] Correct the order of regen-abidump #27228
Closed
@animalize animalize mannequin mentioned this pull request Apr 12, 2022
stdlib wrongly uses len() for bytes-like object #88605
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.