GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-44439: BZ2File.write() / LZMAFile.write() handle buffer protocol correctly · Pull Request #26764 · python/cpython

Conversation

@ghost

@ghost ghost commented Jun 17, 2021 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

The underlying C codes handle buffer protocol objects correctly, so only fix the wrong length in Python code is fine.

https://bugs.python.org/issue44439

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 17, 2021
@bedevere-bot bedevere-bot added the awaiting review label Jun 17, 2021
@wjssz
BZ2File.write()/LZMAFile.write() handle length correctly
5884185 
No longer use len() to get the length of the input data. For some buffer protocol objects, the length obtained by using len() is wrong.
serhiy-storchaka
serhiy-storchaka reviewed Jun 22, 2021
View reviewed changes
Comment thread Lib/test/test_gzip.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/bz2.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@wjssz
address review comment
d069c7e
serhiy-storchaka
serhiy-storchaka approved these changes Jun 22, 2021
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 22, 2021
@serhiy-storchaka serhiy-storchaka added needs backport to 3.9 labels Jun 22, 2021
@serhiy-storchaka
serhiy-storchaka merged commit bc6c12c into python:main Jun 22, 2021
@miss-islington

miss-islington commented Jun 22, 2021

Copy link
Copy Markdown
Contributor

Thanks @animalize for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 22, 2021
@miss-islington

miss-islington commented Jun 22, 2021

Copy link
Copy Markdown
Contributor

Sorry, @animalize and @serhiy-storchaka, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker bc6c12c72a9536acc96e7b9355fd69d1083a43c1 3.9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned serhiy-storchaka Jun 22, 2021
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Jun 22, 2021
@bedevere-bot

bedevere-bot commented Jun 22, 2021

Copy link
Copy Markdown

GH-26845 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 22, 2021
@miss-islington
bpo-44439: BZ2File.write() / LZMAFile.write() handle buffer protocol …
559d927 
…correctly (pythonGH-26764)

No longer use len() to get the length of the input data. For some buffer protocol objects,
the length obtained by using len() is wrong.
(cherry picked from commit bc6c12c)

Co-authored-by: Ma Lin <[email protected]>
@ghost
ghost deleted the input_len branch June 22, 2021 07:12
@ghost ghost mentioned this pull request Jun 22, 2021
[3.9] bpo-44439: BZ2File.write()/LZMAFile.write() handle length correctly #26846
Merged
@ghost

ghost commented Jun 22, 2021

Copy link
Copy Markdown
Author

3.9 branch has a code conflict, I created PR #26846 for 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka pushed a commit that referenced this pull request Jun 22, 2021
@miss-islington
bpo-44439: BZ2File.write() / LZMAFile.write() handle buffer protocol …
01858fb 
…correctly (GH-26764) (GH-26845)

No longer use len() to get the length of the input data. For some buffer protocol objects,
the length obtained by using len() is wrong.
(cherry picked from commit bc6c12c)

Co-authored-by: Ma Lin <[email protected]>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
[3.10] Correct the order of regen-abidump #27228
Closed
@animalize animalize mannequin mentioned this pull request Apr 12, 2022
stdlib wrongly uses len() for bytes-like object #88605
Closed
@serhiy-storchaka serhiy-storchaka removed the needs backport to 3.9 label Nov 10, 2023
@serhiy-storchaka serhiy-storchaka removed their assignment Nov 10, 2023
@eachimei eachimei mentioned this pull request Nov 11, 2026
pickle docs: Pickler's file.write() can receive bytes-like objects, not only bytes #161803
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni @wjssz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.