GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] bpo-44439: BZ2File.write()/LZMAFile.write() handle length correctly · Pull Request #26846 · python/cpython

Conversation

@ghost

@ghost ghost commented Jun 22, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

No longer use len() to get the length of the input data. For some buffer protocol objects, the length obtained by using len() is wrong.

Co-authored-by: Marco Ribeiro [email protected]

backport of #26764

Marco Ribeiro reported and provided the fix in https://github.com/animalize/pyzstd/issues/4, so I list him as a co-author.

https://bugs.python.org/issue44439

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@wjssz @marcoffee
BZ2File.write()/LZMAFile.write() handle length correctly
720bed4 
No longer use len() to get the length of the input data. For some buffer protocol objects, the length obtained by using len() is wrong.

Co-authored-by: Marco Ribeiro <[email protected]>
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 22, 2021
@bedevere-bot bedevere-bot added the awaiting review label Jun 22, 2021
@ghost ghost mentioned this pull request Jun 22, 2021
bpo-44439: BZ2File.write() / LZMAFile.write() handle buffer protocol correctly #26764
Merged
@ghost ghost changed the title [3.9] BZ2File.write()/LZMAFile.write() handle length correctly [3.9] bpo-44439: BZ2File.write()/LZMAFile.write() handle length correctly Jun 22, 2021
serhiy-storchaka
serhiy-storchaka approved these changes Jun 22, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 22, 2021
@serhiy-storchaka
serhiy-storchaka merged commit 8bc26d8 into python:3.9 Jun 22, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 22, 2021
@ghost
ghost deleted the len_3.9 branch June 22, 2021 14:37
@animalize animalize mannequin mentioned this pull request Apr 12, 2022
stdlib wrongly uses len() for bytes-like object #88605
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@serhiy-storchaka @the-knights-who-say-ni @bedevere-bot @wjssz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.