GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-30511: Add note on thread safety to shutil.make_archive() by akulakov · Pull Request #26933 · python/cpython

Conversation

@akulakov

@akulakov akulakov commented Jun 28, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue30511

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
akulakov added 2 commits June 28, 2021 09:11
@akulakov
Add note on thread safety to make_archive()
b66585b
@akulakov
add blank line
8abff85
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 28, 2021
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir labels Jun 28, 2021
@ambv
Add Blurb
217bcf4
@ambv ambv added needs backport to 3.8 labels Jul 21, 2021
@ambv
ambv merged commit 64f54b7 into python:main Jul 21, 2021
@bedevere-bot

bedevere-bot commented Jul 21, 2021

Copy link
Copy Markdown

@ambv: Please replace # with GH- in the commit message next time. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 21, 2021

Copy link
Copy Markdown
Contributor

Thanks @akulakov for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.8, 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed awaiting review needs backport to 3.10 labels Jul 21, 2021
@bedevere-bot

bedevere-bot commented Jul 21, 2021

Copy link
Copy Markdown

GH-27274 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 21, 2021
@akulakov @miss-islington
bpo-30511: Add note on thread safety to shutil.make_archive() (python…
b4573f7 
…GH-26933)

Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 64f54b7)

Co-authored-by: andrei kulakov <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 21, 2021

Copy link
Copy Markdown

GH-27275 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Jul 21, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 21, 2021
@akulakov @miss-islington
bpo-30511: Add note on thread safety to shutil.make_archive() (python…
51b379c 
…GH-26933)

Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 64f54b7)

Co-authored-by: andrei kulakov <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 21, 2021

Copy link
Copy Markdown

GH-27276 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Jul 21, 2021
sthagen added a commit to sthagen/python-cpython that referenced this pull request Jul 21, 2021
@sthagen
Merge pull request #548 from python/main
d91fccd 
bpo-30511: Add note on thread safety to shutil.make_archive() (python#26933)
ambv pushed a commit that referenced this pull request Jul 21, 2021
@miss-islington @akulakov
bpo-30511: Add note on thread safety to shutil.make_archive() (GH-26933…
d17449f 
…) (GH-27274)

Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 64f54b7)

Co-authored-by: andrei kulakov <[email protected]>
ambv pushed a commit that referenced this pull request Jul 21, 2021
@miss-islington @akulakov
bpo-30511: Add note on thread safety to shutil.make_archive() (GH-26933…
54d3871 
…) (#27276)

Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 64f54b7)

Co-authored-by: andrei kulakov <[email protected]>
ambv pushed a commit that referenced this pull request Jul 21, 2021
@miss-islington @akulakov
bpo-30511: Add note on thread safety to shutil.make_archive() (GH-26933…
c8e35ab 
…) (GH-27275)

Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 64f54b7)

Co-authored-by: andrei kulakov <[email protected]>
@AlexGaynor AlexGaynor mannequin mentioned this pull request Apr 10, 2022
shutil.make_archive should not need to chdir (alternatively: make shutil.make_archive thread-safe) #74696
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@akulakov @bedevere-bot @miss-islington @ambv @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.