GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43950: implement on-the-fly source tracking for interactive mode by isidentical · Pull Request #27117 · python/cpython

Conversation

@isidentical

@isidentical isidentical commented Jul 13, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Purely for design purposes, do not review/merge.

https://bugs.python.org/issue43950

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jul 13, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Jul 13, 2021
@isidentical isidentical added DO-NOT-MERGE skip news labels Jul 13, 2021
@isidentical
isidentical force-pushed the bpo-43950-source-tracking branch from d5c62e3 to ea92deb Compare July 13, 2021 17:00
@isidentical
bpo-43950: implement on-the-fly source tracking for interactive mode
3d2919c
@isidentical
isidentical force-pushed the bpo-43950-source-tracking branch from ea92deb to 3d2919c Compare July 13, 2021 17:33
@isidentical

isidentical commented Jul 17, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

One problem with this patch is that, we need to limit fetching from __source__ only for the main frame, otherwise if the offsets match out it will show something like this;

 $ ./python
Python 3.11.0a0 (heads/[bpo-43950](https://bugs.python.org/issue43950)-source-tracking-dirty:1173c11e09, Jul 17 2021, 14:52:40) [GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> def frame_3():
...     return 1/0
... 
>>> def frame_2():
...     return frame_3()
... 
>>> def frame_1():
...     return frame_2()
... 
>>> if True:
...     1+     frame_1()
... 
Traceback (most recent call last):
  File "<stdin>", line 2, in <module>
    1+     frame_1()
           ^^^^^^^^^
  File "<stdin>", line 2, in frame_1
    1+     frame_1()
           ^^^^^^^^^
  File "<stdin>", line 2, in frame_2
    1+     frame_1()
           ^^^^^^^^^
  File "<stdin>", line 2, in frame_3
    1+     frame_1()
           ^^^
ZeroDivisionError: division by zero
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions

github-actions Bot commented Aug 17, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Aug 17, 2021
@isidentical isidentical mentioned this pull request Jan 20, 2022
bpo-46441: Add a regression test for caret position #30720
Merged
@pablogsal pablogsal mentioned this pull request Apr 13, 2022
Include column offsets for bytecode instructions #88116
Closed
@thatbirdguythatuknownot thatbirdguythatuknownot mentioned this pull request May 16, 2022
bpo-43950: Implement fine grained error locations for interactive mode #92827
Closed
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Aug 10, 2022
@CAM-Gerlach

CAM-Gerlach commented Oct 16, 2022

Copy link
Copy Markdown
Member

Hey @isidentical , can this be closed now?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@isidentical

isidentical commented Oct 17, 2022

Copy link
Copy Markdown
Member Author

Thanks for the reminder @CAM-Gerlach, this was mainly an experiment before it ever got to be a real PR so yep we can close it.

CAM-Gerlach reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@isidentical isidentical closed this Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal will be requested when the pull request is marked ready for review pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou will be requested when the pull request is marked ready for review lysnikolaou is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently will be requested when the pull request is marked ready for review ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review DO-NOT-MERGE skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@isidentical @CAM-Gerlach @the-knights-who-say-ni @ezio-melotti @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.