GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||
GeezerVison is showing github.com — bpo-43950: Implement fine grained error locations for interactive mode by thatbirdguythatuknownot · Pull Request #92827 · python/cpython Conversation
|
|
I'm confused. The original PR #27117 is still open, even if it is a draft and the original design questions already remain. Why have you opened another PR? Have you contacted @isidentical first to take his code/approach? We still need to decide if this is a good idea because this has drawbacks, which is one of the reasons we didn't pursue this originally. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Alright, so I have to close this one? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Well, you don't have to but the aspects and questions I have mentioned still stand. Particularly and most importantly, if you have taken code directly from #27117 then you need first to have the author's permission, otherwise, we won't be able to merge this even if we wanted. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
My PR can be used as a baseline, no worries on that end (though I have some reservations about the implementation, especially the new code field). |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Yeah, that's what I dislike the most and I think this may make it a no-go. At the end of the day the reason we left it there was because the extra overhead and complexity was not worth the advantages as other reprls like Ipython will not even benefit from it. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
After thinking about this I am -1 as the complexity introduced by this is quite high to just cover interactive mode. Unless @isidentical think otherwise, we should close this PR. Thanks @thatbirdguythatuknownot for the prototype and for persuing the idea. Unfortunately this is one of the cases where the complexity introduced unfortunately doesn't balance well with the feature. I think we could probably do it better in the future implementing interactive mode over temporary files |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Alright, I'll close this PR. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.