GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-44184: Apply GH-26274 to the non-GC-type branch of subtype_dealloc. by Yhg1s · Pull Request #27165 · python/cpython

Conversation

@Yhg1s

@Yhg1s Yhg1s commented Jul 15, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The non-GC-type branch of subtype_dealloc is using the type of an object after freeing in the same unsafe way as GH-26274 fixes. (I believe the old news entry covers this change well enough.)

https://bugs.python.org/issue44184

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Yhg1s
Apply pythonGH-26274 to the non-GC-type branch of subtype_dealloc, as…
f098930 
… it is also

trying to use a type after it's potentially been freed.
@Yhg1s Yhg1s added skip news needs backport to 3.9 labels Jul 15, 2021
@Yhg1s
Yhg1s requested a review from vstinner July 15, 2021 14:11
@Yhg1s
Yhg1s requested a review from markshannon as a code owner July 15, 2021 14:11
@bedevere-bot bedevere-bot added the awaiting core review label Jul 15, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jul 15, 2021
pablogsal
pablogsal approved these changes Jul 15, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 15, 2021
pablogsal
pablogsal reviewed Jul 15, 2021
View reviewed changes
Comment thread Objects/typeobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Yhg1s
Yhg1s merged commit 074e765 into python:main Jul 15, 2021
@miss-islington

miss-islington commented Jul 15, 2021

Copy link
Copy Markdown
Contributor

Thanks @Yhg1s for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed awaiting merge needs backport to 3.10 labels Jul 15, 2021
@bedevere-bot

bedevere-bot commented Jul 15, 2021

Copy link
Copy Markdown

GH-27174 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 15, 2021
@Yhg1s @miss-islington
bpo-44184: Apply pythonGH-26274 to the non-GC-type branch of subtype_…
f2302d8 
…dealloc (pythonGH-27165)

The non-GC-type branch of subtype_dealloc is using the type of an object after freeing in the same unsafe way as pythonGH-26274 fixes. (I believe the old news entry covers this change well enough.)

https://bugs.python.org/issue44184
(cherry picked from commit 074e765)

Co-authored-by: T. Wouters <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 15, 2021

Copy link
Copy Markdown

GH-27175 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Jul 15, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 15, 2021
@Yhg1s @miss-islington
bpo-44184: Apply pythonGH-26274 to the non-GC-type branch of subtype_…
48ad320 
…dealloc (pythonGH-27165)

The non-GC-type branch of subtype_dealloc is using the type of an object after freeing in the same unsafe way as pythonGH-26274 fixes. (I believe the old news entry covers this change well enough.)

https://bugs.python.org/issue44184
(cherry picked from commit 074e765)

Co-authored-by: T. Wouters <[email protected]>
@Yhg1s
Yhg1s deleted the subtype_dealloc branch July 15, 2021 22:41
Yhg1s added a commit that referenced this pull request Jul 15, 2021
@miss-islington @Yhg1s
bpo-44184: Apply GH-26274 to the non-GC-type branch of subtype_dealloc (
6aa59c6 
GH-27165) (GH-27174)

The non-GC-type branch of subtype_dealloc is using the type of an object after freeing in the same unsafe way as GH-26274 fixes. (I believe the old news entry covers this change well enough.)

https://bugs.python.org/issue44184
(cherry picked from commit 074e765)

Co-authored-by: T. Wouters <[email protected]>
Yhg1s added a commit that referenced this pull request Jul 15, 2021
@miss-islington @Yhg1s
bpo-44184: Apply GH-26274 to the non-GC-type branch of subtype_dealloc (
0b47049 
GH-27165) (GH-27175)

The non-GC-type branch of subtype_dealloc is using the type of an object after freeing in the same unsafe way as GH-26274 fixes. (I believe the old news entry covers this change well enough.)

https://bugs.python.org/issue44184
(cherry picked from commit 074e765)

Co-authored-by: T. Wouters <[email protected]>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
[3.10] Correct the order of regen-abidump #27228
Closed
@Yhg1s
Yhg1s restored the subtype_dealloc branch June 6, 2023 15:04
@Yhg1s
Yhg1s deleted the subtype_dealloc branch November 22, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@vstinner vstinner Awaiting requested review from vstinner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Yhg1s @miss-islington @bedevere-bot @pablogsal @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.