GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix small typos in introduction and datastructures of tutorial by DimitrisJim · Pull Request #272 · python/cpython

Conversation

@DimitrisJim

@DimitrisJim DimitrisJim commented Feb 24, 2017

Copy link
Copy Markdown
Contributor

A couple of small issues:

  • Remove reference to Unicode string in introduction.
  • Fix description of list.extend to mention iterable (and not make it look like only lists are allowed)
  • "subsequence of x" should be "subsequence of the list"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Edgarruiz856 reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@DimitrisJim
Fix small typos in introduction and datastructures
1bc48d3
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 24, 2017
@berkerpeksag berkerpeksag added needs backport to 3.5 labels Feb 24, 2017
berkerpeksag
berkerpeksag approved these changes Feb 24, 2017
View reviewed changes
@wm75

wm75 commented Feb 24, 2017

Copy link
Copy Markdown

Why not change the name of the argument to list.extend from L to i or iterable then?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DimitrisJim

DimitrisJim commented Feb 24, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

The iterable idea sounds like a good idea to me, it would also match the output of help(list.extend). @berkerpeksag should I tweak the signature to match .extends source doc?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@berkerpeksag

berkerpeksag commented Feb 24, 2017

Copy link
Copy Markdown
Member

Changing the signature from L to iterable sounds good to me too.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DimitrisJim
Use iterable instead of L in the doc for list.extend
137a206
@DimitrisJim

DimitrisJim commented Feb 24, 2017

Copy link
Copy Markdown
Contributor Author

Done, thanks for the suggestion, @wm75!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Mariatta
Mariatta approved these changes Feb 25, 2017
View reviewed changes
@Mariatta
Mariatta merged commit 53c1892 into python:master Feb 25, 2017
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Feb 25, 2017
@DimitrisJim @Mariatta
Fix small typos in introduction and datastructures of tutorial (pytho…
12ae3cc 
…nGH-272)

* Fix small typos in introduction and datastructures
* Use iterable instead of L in the doc for list.extend

(cherry picked from commit 53c1892)
@Mariatta Mariatta removed the needs backport to 3.6 label Feb 25, 2017
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Feb 25, 2017
@DimitrisJim @Mariatta
Fix small typos in introduction and datastructures of tutorial (pytho…
56f299f 
…nGH-272)

* Fix small typos in introduction and datastructures
* Use iterable instead of L in the doc for list.extend

(cherry picked from commit 53c1892)
@Mariatta Mariatta mentioned this pull request Feb 25, 2017
[3.5] Fix small typos in introduction and datastructures of tutorial (GH-272) #299
Merged
@Mariatta Mariatta removed the needs backport to 3.5 label Feb 25, 2017
Mariatta added a commit that referenced this pull request Feb 26, 2017
@Mariatta
Fix small typos in introduction and datastructures of tutorial (GH-272)…
b002328 
… (GH-297)

(cherry picked from commit 53c1892)
Mariatta added a commit that referenced this pull request Feb 26, 2017
@Mariatta
[3.5] Fix small typos in introduction and datastructures of tutorial (G…
4c78463 
…H-272) (GH-299)

(cherry picked from commit 5bd5b9d)
(cherry picked from commit 8c5e190)
(cherry picked from commit 53c1892)
@DimitrisJim
DimitrisJim deleted the fix_typos branch March 27, 2017 20:56
akruis added a commit to akruis/cpython that referenced this pull request Jun 15, 2021
@akruis
Stackless issue python#272: convert macro HANDLE_UNWINDING to a function
b325b6e 
Convert most of the macro HANDLE_UNWINDING in ceval.c to a static inline
function handle_inline(). This improves maintainability.
akruis added a commit to akruis/cpython that referenced this pull request Jun 18, 2021
@akruis
Stackless issue python#272: convert macro HANDLE_UNWINDING to a function
f730a4e 
Add some assertions
akruis added a commit to akruis/cpython that referenced this pull request Jun 20, 2021
@akruis
Stackless issue python#272: convert macro HANDLE_UNWINDING to a function
bf0c174 
Convert most of the macro HANDLE_UNWINDING in ceval.c to a static inline
function handle_inline(). This improves maintainability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes
@Mariatta Mariatta Mariatta approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@DimitrisJim @wm75 @berkerpeksag @Mariatta @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.