GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-26184: import.rst: Add versionchanged note by Mariatta · Pull Request #277 · python/cpython

Conversation

@Mariatta

@Mariatta Mariatta commented Feb 24, 2017

Copy link
Copy Markdown
Member

Add versionchanged note indicating that an ImportError is raised when exec_module() is defined, but create_module() is not.

http://bugs.python.org/issue26184

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Mariatta
bpo-26184: import.rst: Add versionchanged note indicating that
6f92989 
an ImportError is raised when exec_module() is defined, but
create_module() is not.
@Mariatta Mariatta added the needs backport to 3.6 label Feb 24, 2017
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 24, 2017
Carreau
Carreau approved these changes Feb 24, 2017
View reviewed changes
@Mariatta Mariatta added the docs Documentation in the Doc dir label Feb 24, 2017
marco-buttu
marco-buttu suggested changes Feb 24, 2017
View reviewed changes

@marco-buttu marco-buttu left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Mariatta , it LGTM, but I would like you to add just a minor change, not directly related with this PR. In the first versionadded of the Loaders section, we do not have any markup for create_module():

.. versionadded:: 3.4
   The create_module() method of loaders.

It should be:

.. versionadded:: 3.4
   The :meth:`~importlib.abc.Loader.create_module`  method of loaders.

Thank you very much

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Mariatta

Mariatta commented Feb 25, 2017

Copy link
Copy Markdown
Member Author

Thanks for the review, @Carreau and @marco-buttu .

@marco-buttu, the change that you requested will require backport to 3.5 and 3.6 branches, whereas this PR will only be backported to 3.6.

I will make that change as a separate PR from this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@marco-buttu

marco-buttu commented Feb 25, 2017

Copy link
Copy Markdown
Contributor

@Mariatta I opened a bpo-29648 issue for the missing reference to create_module(). I am making the PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
marco-buttu
marco-buttu approved these changes Feb 25, 2017
View reviewed changes
@Mariatta
Mariatta merged commit 6b4a5f4 into python:master Feb 26, 2017
Mariatta added a commit to Mariatta/cpython that referenced this pull request Feb 26, 2017
@Mariatta
bpo-26184: import.rst: Improve versionchanged note (pythonGH-277)
dedda76 
Mention that an ImportError is raised when exec_module() is defined, but
create_module() is not.
(cherry picked from commit 6b4a5f4)
@Mariatta
Mariatta deleted the bpo-26184-master branch February 26, 2017 15:42
@Mariatta Mariatta removed the needs backport to 3.6 label Feb 26, 2017
Mariatta added a commit that referenced this pull request Feb 26, 2017
@Mariatta
bpo-26184: import.rst: Improve versionchanged note (GH-277) (#320)
deea29e 
(cherry picked from commit 6b4a5f4)
berkerpeksag
berkerpeksag reviewed Feb 26, 2017
View reviewed changes
Comment thread Doc/reference/import.rst

.. versionchanged:: 3.6
An :exc:`ImportError` is raised when ``exec_module()`` is defined but
``create_module`` is not.

@berkerpeksag berkerpeksag Feb 26, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess create_module should be create_module() here since the latter form is also used in the first versionchanged note.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Mariatta Mariatta Feb 26, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, @berkerpeksag! I fixed it in GH-325

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
akruis added a commit to akruis/cpython that referenced this pull request Jun 30, 2021
@akruis
Stackless issue python#277: Convert Stackless demos to Python3
8487430 
Convert all files to Python3 and run/test them once.
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@dependabot-preview
Bump sentry-sdk from 0.11.2 to 0.12.1 (#277)
13dc739
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag left review comments
+2 more reviewers
@Carreau Carreau Carreau approved these changes
@marco-buttu marco-buttu marco-buttu approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Mariatta @marco-buttu @berkerpeksag @Carreau @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.