GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [3.9] Fix the test suite for the old parser by pablogsal · Pull Request #27749 · python/cpython

Conversation

pablogsal commented Aug 12, 2021

Copy link

Copy Markdown

Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Fix the test suite for the old parser

93e6442

the-knights-who-say-ni added the CLA signed label

Aug 12, 2021

bedevere-bot added the awaiting core review label

Aug 12, 2021

pablogsal changed the title ~~Fix the test suite for the old parser~~ [3.9] Fix the test suite for the old parser

Aug 12, 2021

pablogsal added skip issue skip news labels

Aug 12, 2021

pablogsal requested a review from isidentical

August 12, 2021 21:54

pablogsal force-pushed the oldparser branch from 7be2d61 to 93e6442 Compare

August 12, 2021 21:54

pablogsal commented Aug 12, 2021

Copy link

Copy Markdown

Member Author

./python -Xoldparser ./Tools/scripts/run_tests.py -j 20 -u all -W --slowest --fail-env-changed --timeout=1200
...
== Tests result: SUCCESS ==

412 tests OK.

10 slowest tests:
- test_concurrent_futures: 2 min 32 sec
- test_subprocess: 1 min 56 sec
- test_multiprocessing_spawn: 1 min 19 sec
- test_capi: 1 min 18 sec
- test_asyncio: 1 min 7 sec
- test_gdb: 1 min 6 sec
- test_multiprocessing_forkserver: 1 min 3 sec
- test_unparse: 60.0 sec
- test_tokenize: 55.9 sec
- test_multiprocessing_fork: 54.8 sec

13 tests skipped:
    test_devpoll test_ioctl test_kqueue test_msilib test_ossaudiodev
    test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
    test_winreg test_winsound test_zipfile64

Total duration: 3 min 11 sec
Tests result: SUCCESS

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pablogsal mentioned this pull request

Aug 12, 2021

[3.9] bpo-44885: Correct the ast locations of f-strings with format specs and repeated expressions (GH-27729) #27744

Merged

isidentical approved these changes

Aug 13, 2021

View reviewed changes

isidentical left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix @pablogsal!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/test/test_syntax.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added awaiting merge and removed awaiting core review labels

Aug 13, 2021


          Remove unnecessary skipIf

ambv commented Aug 13, 2021

Copy link

Copy Markdown

Contributor

Confirmed locally tests still pass with the typo fix. Merging.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ambv merged commit 282fc5c into python:3.9

Aug 13, 2021

bedevere-bot removed the awaiting merge label

Aug 13, 2021

bedevere-bot commented Aug 13, 2021

Copy link

Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Arch Linux Asan 3.9 has failed when building commit 282fc5c.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/579/builds/142) and take a look at the build logs.
Check if the failure is related to this commit (282fc5c) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/579/builds/142

Summary of the results of the build (if available):

Click to see traceback logs

remote: Enumerating objects: 7, done.        
remote: Counting objects:  14% (1/7)        
remote: Counting objects:  28% (2/7)        
remote: Counting objects:  42% (3/7)        
remote: Counting objects:  57% (4/7)        
remote: Counting objects:  71% (5/7)        
remote: Counting objects:  85% (6/7)        
remote: Counting objects: 100% (7/7)        
remote: Counting objects: 100% (7/7), done.        
remote: Compressing objects:  20% (1/5)        
remote: Compressing objects:  40% (2/5)        
remote: Compressing objects:  60% (3/5)        
remote: Compressing objects:  80% (4/5)        
remote: Compressing objects: 100% (5/5)        
remote: Compressing objects: 100% (5/5), done.        
remote: Total 7 (delta 2), reused 2 (delta 2), pack-reused 0        
From https://github.com/python/cpython
 * branch                  3.9        -> FETCH_HEAD
Note: switching to '282fc5c00787297f1d7a9b7b1469b51e84f485a9'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 282fc5c007 [3.9] Fix the test suite for the old parser (GH-27749)
Switched to and reset branch '3.9'

./Modules/signalmodule.c: In function ‘signal_siginterrupt_impl’:
./Modules/signalmodule.c:660:5: warning: ‘siginterrupt’ is deprecated: Use sigaction with SA_RESTART instead [-Wdeprecated-declarations]
  660 |     if (siginterrupt(signalnum, flag)<0) {
      |     ^~
In file included from ./Modules/signalmodule.c:28:
/usr/include/signal.h:311:12: note: declared here
  311 | extern int siginterrupt (int __sig, int __interrupt) __THROW
      |            ^~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c: In function ‘word_to_string’:
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |         ^~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:354:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  354 |     case 20: EXTRACT_DIGIT(s, x, 10000000000000000000ULL, dot); /* GCOV_NOT_REACHED */
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:35: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |                                   ^
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:354:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  354 |     case 20: EXTRACT_DIGIT(s, x, 10000000000000000000ULL, dot); /* GCOV_NOT_REACHED */
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |         ^~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:355:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  355 |     case 19: EXTRACT_DIGIT(s, x, 1000000000000000000ULL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:35: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |                                   ^
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:355:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  355 |     case 19: EXTRACT_DIGIT(s, x, 1000000000000000000ULL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |         ^~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:356:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  356 |     case 18: EXTRACT_DIGIT(s, x, 100000000000000000ULL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:35: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |                                   ^
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:356:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  356 |     case 18: EXTRACT_DIGIT(s, x, 100000000000000000ULL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |         ^~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:357:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  357 |     case 17: EXTRACT_DIGIT(s, x, 10000000000000000ULL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:35: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |                                   ^
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:357:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  357 |     case 17: EXTRACT_DIGIT(s, x, 10000000000000000ULL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |         ^~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:358:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  358 |     case 16: EXTRACT_DIGIT(s, x, 1000000000000000ULL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:35: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |                                   ^
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:358:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  358 |     case 16: EXTRACT_DIGIT(s, x, 1000000000000000ULL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |         ^~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:359:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  359 |     case 15: EXTRACT_DIGIT(s, x, 100000000000000ULL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:35: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |                                   ^
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:359:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  359 |     case 15: EXTRACT_DIGIT(s, x, 100000000000000ULL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |         ^~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:360:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  360 |     case 14: EXTRACT_DIGIT(s, x, 10000000000000ULL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:35: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |                                   ^
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:360:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  360 |     case 14: EXTRACT_DIGIT(s, x, 10000000000000ULL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |         ^~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:361:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  361 |     case 13: EXTRACT_DIGIT(s, x, 1000000000000ULL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:35: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |                                   ^
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:361:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  361 |     case 13: EXTRACT_DIGIT(s, x, 1000000000000ULL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |         ^~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:362:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  362 |     case 12: EXTRACT_DIGIT(s, x, 100000000000ULL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:35: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |                                   ^
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:362:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  362 |     case 12: EXTRACT_DIGIT(s, x, 100000000000ULL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |         ^~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:363:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  363 |     case 11: EXTRACT_DIGIT(s, x, 10000000000ULL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:35: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |                                   ^
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:363:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  363 |     case 11: EXTRACT_DIGIT(s, x, 10000000000ULL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |         ^~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:365:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  365 |     case 10: EXTRACT_DIGIT(s, x, 1000000000UL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:35: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |                                   ^
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:365:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  365 |     case 10: EXTRACT_DIGIT(s, x, 1000000000UL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |         ^~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:366:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  366 |     case 9:  EXTRACT_DIGIT(s, x, 100000000UL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:35: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |                                   ^
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:366:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  366 |     case 9:  EXTRACT_DIGIT(s, x, 100000000UL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |         ^~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:367:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  367 |     case 8:  EXTRACT_DIGIT(s, x, 10000000UL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:35: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |                                   ^
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:367:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  367 |     case 8:  EXTRACT_DIGIT(s, x, 10000000UL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |         ^~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:368:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  368 |     case 7:  EXTRACT_DIGIT(s, x, 1000000UL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:35: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |                                   ^
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:368:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  368 |     case 7:  EXTRACT_DIGIT(s, x, 1000000UL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |         ^~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:369:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  369 |     case 6:  EXTRACT_DIGIT(s, x, 100000UL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:35: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |                                   ^
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:369:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  369 |     case 6:  EXTRACT_DIGIT(s, x, 100000UL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |         ^~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:370:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  370 |     case 5:  EXTRACT_DIGIT(s, x, 10000UL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:35: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |                                   ^
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:370:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  370 |     case 5:  EXTRACT_DIGIT(s, x, 10000UL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |         ^~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:371:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  371 |     case 4:  EXTRACT_DIGIT(s, x, 1000UL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:35: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |                                   ^
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:371:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  371 |     case 4:  EXTRACT_DIGIT(s, x, 1000UL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |         ^~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:372:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  372 |     case 3:  EXTRACT_DIGIT(s, x, 100UL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:35: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |                                   ^
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:372:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  372 |     case 3:  EXTRACT_DIGIT(s, x, 100UL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |         ^~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:373:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  373 |     case 2:  EXTRACT_DIGIT(s, x, 10UL, dot);
      |              ^~~~~~~~~~~~~
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:348:35: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  348 |         if (s == dot) *s++ = '.'; *s++ = '0' + (char)(x / d); x %= d
      |                                   ^
/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Modules/_decimal/libmpdec/io.c:373:14: note: in expansion of macro ‘EXTRACT_DIGIT’
  373 |     case 2:  EXTRACT_DIGIT(s, x, 10UL, dot);
      |              ^~~~~~~~~~~~~

test_tk skipped -- Tk unavailable due to TclError: couldn't connect to display ":99"
test_tix skipped -- Tk unavailable due to TclError: couldn't connect to display ":99"
test_ossaudiodev skipped -- [Errno 2] No such file or directory: '/dev/dsp'
test_ioctl skipped -- Unable to open /dev/tty
test_startfile skipped -- object <module 'os' from '/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Lib/os.py'> has no attribute 'startfile'
test_kqueue skipped -- test works only on BSD
==14362==WARNING: AddressSanitizer failed to allocate 0x7fffffffffffffff bytes
==14362==WARNING: AddressSanitizer failed to allocate 0x7fffffffffffffff bytes
==14362==WARNING: AddressSanitizer failed to allocate 0x7fffffffffffffff bytes
test_winconsoleio skipped -- test only relevant on win32
test_devpoll skipped -- test works only on Solaris OS family
test_ttk_guionly skipped -- Tk unavailable due to TclError: couldn't connect to display ":99"
test_zipfile64 skipped -- test requires loads of disk-space bytes and a long time to run
test_flock (__main__.FNTLEINTRTest) ... ok
test_lockf (__main__.FNTLEINTRTest) ... ok
test_read (__main__.OSEINTRTest) ... ok
test_wait (__main__.OSEINTRTest) ... ok
test_wait3 (__main__.OSEINTRTest) ... ok
test_wait4 (__main__.OSEINTRTest) ... ok
test_waitpid (__main__.OSEINTRTest) ... ok
test_write (__main__.OSEINTRTest) ... ok
test_devpoll (__main__.SelectEINTRTest) ... skipped 'need select.devpoll'
test_epoll (__main__.SelectEINTRTest) ... ok
test_kqueue (__main__.SelectEINTRTest) ... skipped 'need select.kqueue'
test_poll (__main__.SelectEINTRTest) ... ok
test_select (__main__.SelectEINTRTest) ... ok
test_sigtimedwait (__main__.SignalEINTRTest) ... ok
test_sigwaitinfo (__main__.SignalEINTRTest) ... ok
test_accept (__main__.SocketEINTRTest) ... ok
test_open (__main__.SocketEINTRTest) ... ok
test_os_open (__main__.SocketEINTRTest) ... ok
test_recv (__main__.SocketEINTRTest) ... ok
test_recvmsg (__main__.SocketEINTRTest) ... ok
test_send (__main__.SocketEINTRTest) ... ok
test_sendall (__main__.SocketEINTRTest) ... ok
test_sendmsg (__main__.SocketEINTRTest) ... ok
test_sleep (__main__.TimeEINTRTest) ... ok

----------------------------------------------------------------------
Ran 24 tests in 7.088s

OK (skipped=2)
test_msilib skipped -- No module named '_msi'
test_winreg skipped -- No module named 'winreg'
test_winsound skipped -- No module named 'winsound'
make: *** [Makefile:1240: buildbottest] Terminated

Cannot open file '/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/test-results.xml' for upload

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

wookayin mentioned this pull request

Sep 18, 2022

Expressions with format specifiers in f-strings have incorrect offsets numirias/semshi#31

Open

pablogsal deleted the oldparser branch

September 24, 2026 17:36

Reviewers

ambv

ambv left review comments

isidentical

isidentical approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.