GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] bpo-44885: Correct the ast locations of f-strings with format specs and repeated expressions (GH-27729) by pablogsal · Pull Request #27744 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Aug 12, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(cherry picked from commit 8e832fb)

Co-authored-by: Pablo Galindo Salgado [email protected]

https://bugs.python.org/issue44885

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
[3.9] bpo-44885: Correct the ast locations of f-strings with format s…
b01000e 
…pecs and repeated expressions (pythonGH-27729).

(cherry picked from commit 8e832fb)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@pablogsal
pablogsal requested a review from lysnikolaou as a code owner August 12, 2021 16:25
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 12, 2021
@bedevere-bot bedevere-bot mentioned this pull request Aug 12, 2021
bpo-44885: Correct the ast locations of f-strings with format specs and repeated expressions #27729
Merged
@bedevere-bot bedevere-bot added the awaiting core review label Aug 12, 2021
@pablogsal
pablogsal force-pushed the backport-8e832fb-3.9 branch from 19b04bf to b01000e Compare August 12, 2021 16:41
@pablogsal
pablogsal merged commit 4b86c9c into python:3.9 Aug 12, 2021
@pablogsal
pablogsal deleted the backport-8e832fb-3.9 branch August 12, 2021 17:46
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 12, 2021
@isidentical

isidentical commented Aug 12, 2021

Copy link
Copy Markdown
Member

@pablogsal does the new tests work under -X oldparser? I am not sure if we have a buildbot that runs with -X oldparser, though I'd assume these would fail since now two parsers disagree about the locations.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Aug 12, 2021

Copy link
Copy Markdown
Member Author

@pablogsal does the new tests work under -X oldparser? I am not sure if we have a buildbot that runs with -X oldparser, though I'd assume these would fail since now two parsers disagree about the locations.

We have one that probably will fail soon :(

I will fix it if I can, but I have already removed some tests to avoid failures. If I cannot fix it we may need to revert :(
isidentical reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Aug 12, 2021

Copy link
Copy Markdown
Member Author

Fixed by #27749
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@pablogsal @isidentical @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.