GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-38291: Update 3.10 WhatsNew with typing.{io|re} DeprecationWarning by Fidget-Spinner · Pull Request #27872 · python/cpython

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented Aug 21, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue38291

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Fidget-Spinner added 2 commits August 21, 2021 22:28
@Fidget-Spinner
Add note about deprecationwarning and tell users how to upgrade
83a1f7a
@Fidget-Spinner
tighten wording
ca373b8
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 21, 2021
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir labels Aug 21, 2021
@Fidget-Spinner Fidget-Spinner added the skip news label Aug 21, 2021
@Fidget-Spinner

Fidget-Spinner commented Aug 21, 2021

Copy link
Copy Markdown
Member Author

@srittau can I trouble you for a review please? It concerns your work :).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner Fidget-Spinner added the needs backport to 3.10 label Aug 21, 2021
@Fidget-Spinner Fidget-Spinner changed the title bpo-38291: Add note about DeprecationWarning when importing from typing.{io|re} bpo-38291: Update 3.10 WhatsNew with typing.{io|re} DeprecationWarning Aug 21, 2021
@Fidget-Spinner
Fidget-Spinner requested a review from gvanrossum August 21, 2021 14:50
srittau
srittau approved these changes Aug 21, 2021
View reviewed changes

@srittau srittau left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Aug 21, 2021
serhiy-storchaka
serhiy-storchaka reviewed Aug 21, 2021
View reviewed changes
Comment thread Doc/whatsnew/3.10.rst
if they want runtime protocols.
(Contributed by Yurii Karabas in :issue:`38908`)

Importing from the ``typing.io`` and ``typing.re`` submodules will now emit

@serhiy-storchaka serhiy-storchaka Aug 21, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is worth to add it in the "Deprecated" section below.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Fidget-Spinner Fidget-Spinner Aug 22, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially I thought no because What's new in 3.8 should have it https://docs.python.org/3/whatsnew/3.8.html#deprecated, but surprisingly it doesn't. So yep we should add it as a proper reminder this time.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Fidget-Spinner
update deprecated section
cd4569c
@ambv
ambv merged commit 1a995b0 into python:main Aug 23, 2021
@miss-islington

miss-islington commented Aug 23, 2021

Copy link
Copy Markdown
Contributor

Thanks @Fidget-Spinner for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 23, 2021
@bedevere-bot

bedevere-bot commented Aug 23, 2021

Copy link
Copy Markdown

GH-27907 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Aug 23, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 23, 2021
@Fidget-Spinner @miss-islington
bpo-38291: Update 3.10 WhatsNew with typing.{io|re} DeprecationWarning (
04ed031 
pythonGH-27872)

(cherry picked from commit 1a995b0)

Co-authored-by: Ken Jin <[email protected]>
miss-islington added a commit that referenced this pull request Aug 23, 2021
@miss-islington @Fidget-Spinner
bpo-38291: Update 3.10 WhatsNew with typing.{io|re} DeprecationWarning (
27f2f62 
GH-27872)

(cherry picked from commit 1a995b0)

Co-authored-by: Ken Jin <[email protected]>
@Fidget-Spinner
Fidget-Spinner deleted the whatsnew_warnings branch August 29, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
+1 more reviewer
@srittau srittau srittau approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@Fidget-Spinner @miss-islington @bedevere-bot @srittau @serhiy-storchaka @ambv @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.