GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45007: Update multissl to openssl 1.1.1l as well by ambv · Pull Request #28044 · python/cpython

Conversation

@ambv

@ambv ambv commented Aug 29, 2021 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This was missed while upgrading CI.

https://bugs.python.org/issue45007

Automerge-Triggered-By: GH:tiran

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ambv
Update multissl to openssl 1.1.1l as well
255c574
@ambv ambv added needs backport to 3.8 labels Aug 29, 2021
@ambv
ambv requested review from tiran and zooba August 29, 2021 16:33
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 29, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Aug 29, 2021
@ambv ambv added the skip news label Aug 29, 2021
tiran
tiran approved these changes Aug 30, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Aug 30, 2021
@tiran tiran added the 🤖 automerge label Aug 30, 2021
@miss-islington
miss-islington merged commit d6cb5dd into python:main Aug 30, 2021
@miss-islington

miss-islington commented Aug 30, 2021

Copy link
Copy Markdown
Contributor

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9, 3.10.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting merge label Aug 30, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 30, 2021
@ambv @miss-islington
bpo-45007: Update multissl to openssl 1.1.1l as well (pythonGH-28044)
43accec
This was missed while upgrading CI.
(cherry picked from commit d6cb5dd)

Co-authored-by: Łukasz Langa <[email protected]>
@miss-islington

miss-islington commented Aug 30, 2021

Copy link
Copy Markdown
Contributor

Sorry, @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d6cb5dd9e19210f5963ff8beadde7ca2fda71574 3.9

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington miss-islington self-assigned this Aug 30, 2021
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Aug 30, 2021
@miss-islington

miss-islington commented Aug 30, 2021

Copy link
Copy Markdown
Contributor

Sorry @ambv, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker d6cb5dd9e19210f5963ff8beadde7ca2fda71574 3.8

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Aug 30, 2021

Copy link
Copy Markdown

GH-28061 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Aug 30, 2021
@bedevere-bot

bedevere-bot commented Aug 30, 2021

Copy link
Copy Markdown

GH-28062 is a backport of this pull request to the 3.9 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tiran pushed a commit to tiran/cpython that referenced this pull request Aug 30, 2021
@ambv @tiran
[3.9] bpo-45007: Update multissl to openssl 1.1.1l as well (pythonGH-…
2fd9bf8
…28044)

This was missed while upgrading CI..
(cherry picked from commit d6cb5dd)

Co-authored-by: Łukasz Langa <[email protected]>
tiran pushed a commit to tiran/cpython that referenced this pull request Aug 30, 2021
@ambv @tiran
[3.8] bpo-45007: Update multissl to openssl 1.1.1l as well (pythonGH-…
b1a866c
…28044)

This was missed while upgrading CI..
(cherry picked from commit d6cb5dd)

Co-authored-by: Łukasz Langa <[email protected]>
@bedevere-bot

bedevere-bot commented Aug 30, 2021

Copy link
Copy Markdown

GH-28063 is a backport of this pull request to the 3.8 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Aug 30, 2021
miss-islington added a commit that referenced this pull request Aug 30, 2021
@miss-islington @ambv
bpo-45007: Update multissl to openssl 1.1.1l as well (GH-28044)
dc46f4c
This was missed while upgrading CI.
(cherry picked from commit d6cb5dd)

Co-authored-by: Łukasz Langa <[email protected]>
ambv added a commit that referenced this pull request Aug 30, 2021
@tiran @ambv
[3.9] bpo-45007: Update multissl to openssl 1.1.1l as well (GH-28044) (…
576803d
…GH-28062)

This was missed while upgrading CI..
(cherry picked from commit d6cb5dd)

Co-authored-by: Łukasz Langa <[email protected]>
ambv added a commit that referenced this pull request Aug 30, 2021
@tiran @ambv
[3.8] bpo-45007: Update multissl to openssl 1.1.1l as well (GH-28044) (…
8371290
…GH-28063)

This was missed while upgrading CI..
(cherry picked from commit d6cb5dd)

Co-authored-by: Łukasz Langa <[email protected]>

Co-authored-by: Łukasz Langa <[email protected]>
@ambv
ambv deleted the multissl branch August 30, 2021 13:08
@ambv
ambv restored the multissl branch August 30, 2021 13:08
@ambv
ambv deleted the multissl branch August 30, 2021 13:08
@ambv
ambv restored the multissl branch August 30, 2021 13:08
@ambv
ambv deleted the multissl branch August 30, 2021 13:08
@bedevere-bot

bedevere-bot commented Aug 30, 2021

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 RHEL8 3.8 has failed when building commit 8371290.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/113/builds/49) and take a look at the build logs.
  4. Check if the failure is related to this commit (8371290) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/113/builds/49

Failed tests:

  • test_readline

Failed subtests:

  • test_auto_history_enabled - test.test_readline.TestReadline

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

409 tests OK.

10 slowest tests:

  • test_concurrent_futures: 2 min 30 sec
  • test_multiprocessing_spawn: 1 min 53 sec
  • test_multiprocessing_forkserver: 1 min 26 sec
  • test_multiprocessing_fork: 1 min 10 sec
  • test_asyncio: 58.9 sec
  • test_tools: 57.1 sec
  • test_tokenize: 53.0 sec
  • test_nntplib: 52.8 sec
  • test_io: 42.3 sec
  • test_lib2to3: 36.7 sec

1 test failed:
test_readline

13 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_ossaudiodev
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

1 re-run test:
test_readline

Total duration: 2 min 35 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL8-aarch64/build/Lib/test/test_readline.py", line 150, in test_auto_history_enabled
    self.assertIn(b"History length: 1\r\n", output)
AssertionError: b'History length: 1\r\n' not found in bytearray(b'dummy input\r\ndummy input\r\nHistory length: 1')
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba Awaiting requested review from zooba
1 more reviewer
@tiran tiran tiran approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@miss-islington miss-islington

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@ambv @miss-islington @bedevere-bot @tiran @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.