GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] bpo-21302: Add clock_nanosleep() implementation for time.sleep() in Linux by Livius90 · Pull Request #28077 · python/cpython

[3.10] bpo-21302: Add clock_nanosleep() implementation for time.sleep() in Linux #28077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Livius90 wants to merge 1 commit into python:3.10 from Livius90:bpo-21302

Uh oh!

There was an error while loading. Please reload this page.
Closed

[3.10] bpo-21302: Add clock_nanosleep() implementation for time.sleep() in Linux #28077

Changes from all commits
Commits
Show all changes
1 commit
Select commit
017efd1
clock_nanosleep() implementation for time.sleep()
Livius90 Aug 30, 2021
File filter
Filter by extension
Clear filters
Conversations
Failed to load comments.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Diff view
Diff view

There are no files selected for viewing

23 changes: 22 additions & 1 deletion 23 Modules/timemodule.c
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@
# define HAVE_CLOCK_GETTIME_RUNTIME 1
#endif

#if (!defined(MS_WINDOWS) && defined(__linux__) && defined(_POSIX_VERSION)) && (_POSIX_VERSION >= 200112L)
# define HAVE_CLOCK_NANOSLEEP 1
Comment thread

@vstinner vstinner Aug 31, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a check in configure.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
#endif

#define SEC_TO_NS (1000 * 1000 * 1000)

/* Forward declarations */
Expand Down Expand Up @@ -2044,6 +2048,23 @@ PyInit_time(void)
return PyModuleDef_Init(&timemodule);
}

#ifndef MS_WINDOWS
static int
sleep_unix(struct timeval timeout)
{
int ret = 0;
#ifdef HAVE_CLOCK_NANOSLEEP
struct timespec request;
request.tv_sec = timeout.tv_sec;
request.tv_nsec = (long)(timeout.tv_usec) * 1000;
Comment thread

@vstinner vstinner Aug 31, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line makes me sad. The caller uses nanosecond resolution (10^-9), then _PyTime_AsTimeval() truncates to microsecond resolution (10^-6).

I would prefer to inline this code in pysleep() and avoid _PyTime_AsTimeval() for the clock_nanosleep() code path.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ret = clock_nanosleep(CLOCK_MONOTONIC, 0, &request, NULL);
Comment thread

@vstinner vstinner Aug 31, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to avoid computing the relative 'timeout' value, but just pass 'deadline' absolute time since it's already computed: use flags=TIMER_ABSTIME.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
#else
ret = select(0, (fd_set *)0, (fd_set *)0, (fd_set *)0, &timeout);
#endif
return ret;
}
#endif

/* Implement pysleep() for various platforms.
When interrupted (or when another error occurs), return -1 and
set an exception; else return 0. */
Expand Down Expand Up @@ -2073,7 +2094,7 @@ pysleep(_PyTime_t secs)
return -1;

Py_BEGIN_ALLOW_THREADS
err = select(0, (fd_set *)0, (fd_set *)0, (fd_set *)0, &timeout);
err = sleep_unix(timeout);
Py_END_ALLOW_THREADS

if (err == 0)
Expand Down
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.