GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-5846: Do not use obsolete unittest functions. by serhiy-storchaka · Pull Request #28303 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Sep 13, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Get rid of use of makeSuite() and findTestCases().
Also make test_math and test_threading_local discoverable.

https://bugs.python.org/issue5846

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka serhiy-storchaka added the skip news label Sep 13, 2021
@serhiy-storchaka
serhiy-storchaka requested a review from erlend-aasland September 13, 2021 06:16
@serhiy-storchaka
serhiy-storchaka requested review from a team, brettcannon, encukou, ericsnowcurrently, ncoghlan and warsaw as code owners September 13, 2021 06:16
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 13, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Sep 13, 2021
erlend-aasland
erlend-aasland requested changes Sep 13, 2021
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use defaultTestLoader instead of creating a new instance whenever possible.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
bpo-5846: Do not use obsolete unittest functions.
af2f55f 
Get rid of use of makeSuite() and findTestCases().
Also make test_math and test_threading_local discoverable.
@serhiy-storchaka
serhiy-storchaka force-pushed the unittest-makesuite branch from 0ec89e5 to af2f55f Compare September 13, 2021 07:24
erlend-aasland
erlend-aasland approved these changes Sep 13, 2021
View reviewed changes
@serhiy-storchaka
serhiy-storchaka merged commit 851811f into python:main Sep 13, 2021
@bedevere-bot bedevere-bot removed the awaiting core review label Sep 13, 2021
@serhiy-storchaka
serhiy-storchaka deleted the unittest-makesuite branch September 13, 2021 07:49
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Sep 13, 2021
Erlend E. Aasland
Merge branch 'main' into fix-issue-5846
db40a08 
Sync with main bco. python#28303
@voidspace voidspace mentioned this pull request May 24, 2023
Deprecate obsolete functions in unittest #50096
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@encukou encukou Awaiting requested review from encukou
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@serhiy-storchaka @erlend-aasland @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.