GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-42135 Correct version slated for importlib.find_loader removal by hugovk · Pull Request #28312 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Sep 13, 2021 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

importlib.find_loader should also be slated for removal in Python 3.12 instead of Python 3.10, like the others in GH-25169, and as documented in:

  • https://docs.python.org/3.10/whatsnew/3.10.html#deprecated
  • https://docs.python.org/3.11/whatsnew/3.10.html#deprecated

https://bugs.python.org/issue42135

Automerge-Triggered-By: GH:brettcannon

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
bpo-42135 Correct version slated for removal
3f9772e 
importlib.find_loader should also be slated for 3.12 like the others in pythonGH-25169 and as documented in https://docs.python.org/3.11/whatsnew/3.10.html#deprecated
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 13, 2021
@bedevere-bot bedevere-bot added the awaiting review label Sep 13, 2021
@brettcannon brettcannon added the needs backport to 3.10 label Sep 13, 2021
@brettcannon

brettcannon commented Sep 13, 2021

Copy link
Copy Markdown
Member

Yep, should be backported. And a news file wouldn't hurt, but the docs are really the key thing along with What's New.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brettcannon brettcannon added the skip news label Sep 13, 2021
brettcannon
brettcannon approved these changes Sep 13, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Sep 13, 2021
@hugovk
bpo-42135 Add news file
4b3f1e1
@hugovk

hugovk commented Sep 13, 2021

Copy link
Copy Markdown
Member Author

News file added.
brettcannon reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brettcannon brettcannon added the 🤖 automerge label Sep 13, 2021
@brettcannon brettcannon self-assigned this Sep 13, 2021
@miss-islington

miss-islington commented Sep 13, 2021

Copy link
Copy Markdown
Contributor

@hugovk: Status check is done, and it's a success ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brettcannon brettcannon removed the 🤖 automerge label Sep 13, 2021
@brettcannon brettcannon closed this Sep 13, 2021
@brettcannon brettcannon reopened this Sep 13, 2021
@brettcannon brettcannon added the 🤖 automerge label Sep 13, 2021
@brettcannon
brettcannon merged commit 9f93018 into python:main Sep 13, 2021
@miss-islington

miss-islington commented Sep 13, 2021

Copy link
Copy Markdown
Contributor

Thanks @hugovk for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed awaiting merge needs backport to 3.10 labels Sep 13, 2021
@bedevere-bot

bedevere-bot commented Sep 13, 2021

Copy link
Copy Markdown

GH-28321 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 13, 2021
@hugovk @miss-islington
bpo-42135 Correct version slated for importlib.find_loader removal (p…
9c61275 
…ythonGH-28312)

importlib.find_loader should also be slated for 3.12 like the others in pythonGH-25169 and as documented in https://docs.python.org/3.11/whatsnew/3.10.htmlGH-deprecated.
(cherry picked from commit 9f93018)

Co-authored-by: Hugo van Kemenade <[email protected]>
brettcannon pushed a commit that referenced this pull request Sep 13, 2021
@miss-islington @hugovk
bpo-42135 Correct version slated for importlib.find_loader removal (G…
a390bb6 
…H-28312) (GH-28321)

importlib.find_loader should also be slated for 3.12 like the others in GH-25169 and as documented in https://docs.python.org/3.11/whatsnew/3.10.htmlGH-deprecated.
(cherry picked from commit 9f93018)

Co-authored-by: Hugo van Kemenade <[email protected]>

Co-authored-by: Hugo van Kemenade <[email protected]>
@hugovk
hugovk deleted the patch-1 branch September 14, 2021 06:28
@brettcannon brettcannon mentioned this pull request Jun 28, 2022
[importlib] Deprecate find_module() & find_loader() mplementations #86301
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@brettcannon brettcannon

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@hugovk @brettcannon @miss-islington @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.