GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45229: Use doctest.DocTestSuite instead of run_doctest by serhiy-storchaka · Pull Request #28468 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Sep 20, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Also use load_tests() for adding tests.

https://bugs.python.org/issue45229

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
bpo-45229: Use doctest.DocTestSuite instead of run_doctest
00bb43c 
Alo use load_tests() for adding tests.
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.9 labels Sep 20, 2021
@serhiy-storchaka
serhiy-storchaka requested a review from rhettinger as a code owner September 20, 2021 07:45
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 20, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Sep 20, 2021
@serhiy-storchaka
serhiy-storchaka merged commit a856364 into python:main Sep 20, 2021
@bedevere-bot bedevere-bot removed the awaiting core review label Sep 20, 2021
@miss-islington

miss-islington commented Sep 20, 2021

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Sep 20, 2021

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a856364cc920d8b16750fd1fadc902efb509754c 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka deleted the regrtest-run_doctest branch September 20, 2021 08:37
@miss-islington miss-islington assigned serhiy-storchaka Sep 20, 2021
@miss-islington

miss-islington commented Sep 20, 2021

Copy link
Copy Markdown
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker a856364cc920d8b16750fd1fadc902efb509754c 3.9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
niyas-sait pushed a commit to niyas-sait/cpython that referenced this pull request Sep 21, 2021
@serhiy-storchaka @niyas-sait
bpo-45229: Use doctest.DocTestSuite instead of run_doctest (pythonGH-…
470b797 
…28468)

Alo use load_tests() for adding tests.
@serhiy-storchaka serhiy-storchaka mentioned this pull request May 16, 2022
Always use unittest for collecting tests in regrtests #89392
Closed
@serhiy-storchaka serhiy-storchaka removed needs backport to 3.9 labels Nov 10, 2023
@serhiy-storchaka serhiy-storchaka removed their assignment Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@serhiy-storchaka @miss-islington @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.