GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40116: Add insertion order bit-vector to dict values to allow dicts to share keys more freely. by markshannon · Pull Request #28520 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Sep 22, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

See faster-cpython/ideas#30 (comment)

https://bugs.python.org/issue40116

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@markshannon
Add insertion order bit-vector to dict values to allow dicts to share…
8214006
… keys more freely.
@markshannon
markshannon requested a review from methane as a code owner September 22, 2021 15:05
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 22, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Sep 22, 2021
@markshannon markshannon added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 22, 2021
@bedevere-bot

bedevere-bot commented Sep 22, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 8214006 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 22, 2021
@markshannon

markshannon commented Sep 22, 2021

Copy link
Copy Markdown
Member Author

No significant performance change https://gist.github.com/markshannon/814e38650cbe4ba1639e31294d4879e6

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@markshannon
Add NEWS
45c9814
methane
methane reviewed Sep 28, 2021
View reviewed changes
Comment thread Objects/dictobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

methane
methane reviewed Sep 28, 2021
View reviewed changes
Comment thread Objects/dictobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Objects/dictobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Objects/dictobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

@markshannon
Fix Windows warnings and clarify expressions.
51c1ec8
@markshannon markshannon added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 1, 2021
@bedevere-bot

bedevere-bot commented Oct 1, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 51c1ec8 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 1, 2021
@markshannon

markshannon commented Oct 1, 2021

Copy link
Copy Markdown
Member Author

Despite providing no speedup, I'd like to merge this, as it enables compact objects.
Work-in-progress implementation of compact objects here: https://github.com/faster-cpython/cpython/tree/inline-attributes-with-opt (there are a few leaks that I need to hunt down, and some general cleanup to be done).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@markshannon
Fix compiler warning.
2a13a2d
@markshannon markshannon added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 1, 2021
@bedevere-bot

bedevere-bot commented Oct 1, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 2a13a2d 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 1, 2021
@markshannon

markshannon commented Oct 4, 2021

Copy link
Copy Markdown
Member Author

The build bot failures are cancellations (presumably timeouts).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@markshannon

markshannon commented Oct 6, 2021

Copy link
Copy Markdown
Member Author

I'm merging this now as I have https://github.com/faster-cpython/cpython/tree/inline-attributes-with-opt working and it shows measurable speedups as well as reduced memory consumption.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@markshannon
markshannon merged commit a7252f8 into python:main Oct 6, 2021
@bedevere-bot bedevere-bot removed the awaiting core review label Oct 6, 2021
@markshannon
markshannon deleted the dict-order-bit-vector branch October 6, 2021 12:20
methane
methane reviewed Feb 24, 2022
View reviewed changes
Comment thread Objects/dictobject.c
hash = entry->me_hash;
if (other->ma_values)
value = other->ma_values[i];
value = other->ma_values->values[i];

@methane methane Feb 24, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that this change may break order of merged dict.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
methane added a commit to methane/cpython that referenced this pull request Feb 24, 2022
@methane
bpo-40116: dict: Fix regression caused by pythonGH-28520.
7b95b69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@markshannon @bedevere-bot @methane @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.