GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45229: Make tkinter tests discoverable by serhiy-storchaka · Pull Request #28637 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Sep 29, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue45229

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
bpo-45229: Make tkinter tests discoverable
53d74c9
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.9 labels Sep 29, 2021
@serhiy-storchaka
serhiy-storchaka requested a review from a team as a code owner September 29, 2021 20:24
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 29, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Sep 29, 2021
@ambv ambv added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 6, 2021
@bedevere-bot

bedevere-bot commented Oct 6, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ambv for commit 53d74c9 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 6, 2021
@ambv
ambv merged commit f59ed3c into python:main Oct 13, 2021
@miss-islington

miss-islington commented Oct 13, 2021

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Oct 13, 2021
@miss-islington

miss-islington commented Oct 13, 2021

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f59ed3c310a7ceebf2a56a84ea969a7f75d95b64 3.9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned ambv Oct 13, 2021
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Oct 13, 2021
@bedevere-bot

bedevere-bot commented Oct 13, 2021

Copy link
Copy Markdown

GH-28927 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 13, 2021
@serhiy-storchaka @miss-islington
bpo-45229: Make tkinter tests discoverable (pythonGH-28637)
195de49 
(cherry picked from commit f59ed3c)

Co-authored-by: Serhiy Storchaka <[email protected]>
ambv pushed a commit to ambv/cpython that referenced this pull request Oct 13, 2021
@serhiy-storchaka @ambv
[3.9] bpo-45229: Make tkinter tests discoverable (pythonGH-28637).
1435b3f 
(cherry picked from commit f59ed3c)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot

bedevere-bot commented Oct 13, 2021

Copy link
Copy Markdown

GH-28929 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Oct 13, 2021
ambv pushed a commit that referenced this pull request Oct 13, 2021
@miss-islington @serhiy-storchaka
bpo-45229: Make tkinter tests discoverable (GH-28637) (GH-28927)
151234f 
(cherry picked from commit f59ed3c)

Co-authored-by: Serhiy Storchaka <[email protected]>
ambv added a commit that referenced this pull request Oct 13, 2021
@ambv @serhiy-storchaka
[3.9] bpo-45229: Make tkinter tests discoverable (GH-28637) (GH-28929)
5d74713 
(cherry picked from commit f59ed3c)

Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka serhiy-storchaka mentioned this pull request May 16, 2022
Always use unittest for collecting tests in regrtests #89392
Closed
@serhiy-storchaka
serhiy-storchaka deleted the test-tkinter-discover branch July 1, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ambv ambv

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@serhiy-storchaka @bedevere-bot @miss-islington @ambv @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.