GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45391: mark UnionType as a class in documentation by gaborbernat · Pull Request #28757 · python/cpython

Conversation

@gaborbernat

@gaborbernat gaborbernat commented Oct 6, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor 
❯ sphobjinv suggest ./build/html/objects.inv UnionType
:py:class:`types.UnionType`

Signed-off-by: Bernát Gábor [email protected]

https://bugs.python.org/issue45391

Things to consider the type does show up as class now in documentation:
Screenshot 2021-10-06 at 13 43 14
vs before
Screenshot 2021-10-06 at 13 44 36

This PR only addresses the instance in the issue report, but we should discuss if we should change all such instances in this file (there are quite a few others suffering from the same problem).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gaborbernat
bpo-45391: UnionType is a class not data
20da064 
Signed-off-by: Bernát Gábor <[email protected]>
@bedevere-bot bedevere-bot added the awaiting review label Oct 6, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 6, 2021
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Oct 6, 2021
@Fidget-Spinner Fidget-Spinner added needs backport to 3.10 skip news labels Oct 6, 2021
serhiy-storchaka
serhiy-storchaka approved these changes Oct 6, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 6, 2021
@github-actions

github-actions Bot commented Nov 6, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Nov 6, 2021
@merwok merwok changed the title bpo-45391: UnionType is a class not data bpo-45391: make UnionType as a class in documentation Nov 6, 2021
@merwok merwok changed the title bpo-45391: make UnionType as a class in documentation bpo-45391: mark UnionType as a class in documentation Nov 6, 2021
AlexWaygood
AlexWaygood approved these changes Dec 8, 2021
View reviewed changes
@AlexWaygood
AlexWaygood requested a review from Fidget-Spinner December 8, 2021 16:14
Fidget-Spinner
Fidget-Spinner approved these changes Dec 9, 2021
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm merging this as this is more straightforward than the rest of the list mentioned on the bpo. Those need more deliberation.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@Fidget-Spinner
Fidget-Spinner merged commit e2cfc89 into python:main Dec 9, 2021
@miss-islington

miss-islington commented Dec 9, 2021

Copy link
Copy Markdown
Contributor

Thanks @gaborbernat for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 9, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 9, 2021
@gaborbernat @miss-islington
bpo-45391: mark UnionType as a class in documentation (pythonGH-28757)
6e46fab 
Signed-off-by: Bernát Gábor <[email protected]>
(cherry picked from commit e2cfc89)

Co-authored-by: Bernát Gábor <[email protected]>
@bedevere-bot

bedevere-bot commented Dec 9, 2021

Copy link
Copy Markdown

GH-30004 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Dec 9, 2021
@Fidget-Spinner

Fidget-Spinner commented Dec 9, 2021

Copy link
Copy Markdown
Member

Thanks @gaborbernat for catching this, and thank you @AlexWaygood for reminding me to check this PR.
AlexWaygood reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request Dec 9, 2021
@miss-islington @gaborbernat
bpo-45391: mark UnionType as a class in documentation (GH-28757)
2c2ee83 
Signed-off-by: Bernát Gábor <[email protected]>
(cherry picked from commit e2cfc89)

Co-authored-by: Bernát Gábor <[email protected]>
@gaborbernat gaborbernat mannequin mentioned this pull request Sep 21, 2022
Intersphinx inventory classifies some type-like objects as data #89554
Open
@gaborbernat gaborbernat mentioned this pull request May 31, 2026
gh-89554: Document standard type objects in types as classes #150676
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes
@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@gaborbernat @miss-islington @bedevere-bot @Fidget-Spinner @serhiy-storchaka @AlexWaygood @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.