GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] Fix dataclassses spelling (GH-28837) by miss-islington · Pull Request #28841 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Oct 9, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 5b4a767)

Co-authored-by: Landon Yarrington [email protected]

Automerge-Triggered-By: GH:ericvsmith

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jly36963 @miss-islington
Fix dataclassses spelling (pythonGH-28837)
ab5b1bc 
(cherry picked from commit 5b4a767)

Co-authored-by: Landon Yarrington <[email protected]>
@miss-islington
miss-islington requested a review from ericvsmith as a code owner October 9, 2021 19:18
@bedevere-bot bedevere-bot added the awaiting review label Oct 9, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Oct 9, 2021
@the-knights-who-say-ni

the-knights-who-say-ni commented Oct 9, 2021

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@jly36963

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot mentioned this pull request Oct 9, 2021
Fix dataclassses spelling #28837
Merged
@bedevere-bot bedevere-bot added skip issue skip news labels Oct 9, 2021
ericvsmith
ericvsmith approved these changes Oct 9, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 9, 2021
@ericvsmith ericvsmith added the 🤖 automerge label Oct 9, 2021
@miss-islington

miss-islington commented Oct 9, 2021

Copy link
Copy Markdown
Contributor Author

@jly36963 and @ericvsmith: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericvsmith
ericvsmith merged commit e086bfe into python:3.10 Oct 9, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 9, 2021
@miss-islington
miss-islington deleted the backport-5b4a767-3.10 branch October 9, 2021 19:50
@ericvsmith ericvsmith added the needs backport to 3.9 label Oct 9, 2021
@miss-islington

miss-islington commented Oct 9, 2021

Copy link
Copy Markdown
Contributor Author

Thanks @miss-islington for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Oct 9, 2021

Copy link
Copy Markdown
Contributor Author

Sorry, @miss-islington and @ericvsmith, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e086bfee035eb23397f3cddba07b767b35d7ec08 3.9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned ericvsmith Oct 9, 2021
@ZeroIntensity ZeroIntensity removed the needs backport to 3.9 label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericvsmith ericvsmith ericvsmith approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ericvsmith ericvsmith

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@miss-islington @the-knights-who-say-ni @ericvsmith @bedevere-bot @ZeroIntensity @jly36963
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.